tl;dr: When saving a node type form Rabbit Hole's form altering will cause additional garbage variables to be saved to the DB that are not used anywhere.

When editing a node type:

  1. rh_node alters the node type form and calls rabbit_hole_form().
  2. rabbit_hole_form() adds several fieldsets without #tree = TRUE. Child elements will therefore have their values added to the form root.
  3. rabbit_hole_form() adds multiple #value elements to the form to pass along internal values. These are:
    • rh_module
    • redirect_setting_name
  4. When submitting the form, node_type_form_submit() will take any excess values from the root level, suffix their names with the node type name and save the resulting key as variable. This produces two garbage variables per node type that are never requested or reused.

Comments

ciss created an issue. See original summary.

  • Matroskeen committed a9e0d39 on 7.x-2.x
    Issue #2918758 by ciss: Rabbit Hole Node creates garbage variables when...
matroskeen’s picture

Status: Active » Fixed

Nice catch!
The fix was applied to 7.x-2.x.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.