Hello,

I have detected problems in the config schema of this module with config inspector.

I was going to propose a patch but I see on the project page that there won't be any further development? Is it because it will be integrated in core or because of a maintainer needed?

Can I still propose a patch? Or can I propose to become a co-maintainer? The module seems to work fine for its purpose and so only some cleaning are required.

Thanks for the reply.

CommentFileSizeAuthor
#3 2916575-3.patch1.64 KBwim leers

Comments

Grimreaper created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Sorry for the very slow response :(

The answer used to be that the people maintaining this module were just working on getting Drupal core 8.0.0 shipped: #2505467: Is this module abandoned?. But that's of course a very long time ago now.

Honestly, I had completely forgotten about this module! This patch would still be more than welcome :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Configuration system
StatusFileSize
new 2916575-3.patch1.64 KB

I just quickly took a look at it with config_inspector and spotted the same problems you did:

  1. incorrect indentation led to not the entire config schema to be interpreted as it was meant to
  2. using type: mapping instead of type: config_object for the top-level key meant that the _core key was not recognized

… plus some typos.

All fixed.

  • Wim Leers committed c3e7fc0 on 8.x-1.x 
    Issue #2916575 by Wim Leers, Grimreaper: Fix config schema errors
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Update config schema » Fix config schema errors
Status: Active » Fixed

Credited you too, @Grimreaper!

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hello @Wim Leers,

I had completely forgotten opening this issue.

Thanks for the credit!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.