Add PayPal Credit support.

https://developers.braintreepayments.com/guides/paypal/paypal-credit/jav...

CommentFileSizeAuthor
#12 commerce_braintree-paypal_credit-2916512-12.patch6.73 KBczigor
#8 commerce_braintree-paypal_credit-2916512-8.patch6.08 KBczigor
#7 commerce_braintree-paypal_credit-2916512-7.patch0 bytesczigor
#6 interdiff-5-6.txt1.47 KBczigor
#6 commerce_braintree-paypal_credit-2916512-6.patch29.14 KBczigor
#5 commerce_braintree-paypal_credit-2916512-5.patch28.93 KBczigor
#4 commerce_braintree-paypal_credit-2916512-4.patch28.78 KBczigor
#2 commerce_braintree-paypal_credit-2916512-2.patch28.04 KBczigor

Comments

czigor created an issue. See original summary.

czigor’s picture

czigor commented
Status: Active » Needs review
StatusFileSize
new commerce_braintree-paypal_credit-2916512-2.patch28.04 KB

This patch contains the patch in #2331119-39: PayPal support, so we need to remove it from here once it gets committed.

Status: Needs review » Needs work

The last submitted patch, 2: commerce_braintree-paypal_credit-2916512-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

czigor’s picture

czigor commented
Status: Needs work » Needs review
StatusFileSize
new commerce_braintree-paypal_credit-2916512-4.patch28.78 KB

Adding the paypal_credit configuration to the schema.

czigor’s picture

czigor commented
StatusFileSize
new commerce_braintree-paypal_credit-2916512-5.patch28.93 KB

Implementing paypal credit as a new PaymentMethodType instead. The patch still contains the patch in #2331119-39: PayPal support too.

czigor’s picture

czigor commented
StatusFileSize
new commerce_braintree-paypal_credit-2916512-6.patch29.14 KB
new interdiff-5-6.txt1.47 KB

Some additional fixes. (Interdiff is just a diff.)

czigor’s picture

czigor commented
StatusFileSize
new commerce_braintree-paypal_credit-2916512-7.patch0 bytes

Reroll after #2331119: PayPal support got committed.

czigor’s picture

czigor commented
StatusFileSize
new commerce_braintree-paypal_credit-2916512-8.patch6.08 KB

0 bytes has advantages too, but this is better.

czigor’s picture

czigor commented

The last submitted patch, 7: commerce_braintree-paypal_credit-2916512-7.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 8: commerce_braintree-paypal_credit-2916512-8.patch, failed testing. View results

czigor’s picture

czigor commented
StatusFileSize
new commerce_braintree-paypal_credit-2916512-12.patch6.73 KB

Fixing some variable naming and adding some code comments.

czigor’s picture

czigor commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: commerce_braintree-paypal_credit-2916512-12.patch, failed testing. View results

czigor’s picture

czigor commented
Status: Needs work » Needs review

Failing b/c of #2919773: Fail to download drupal/coder because github.com/klausi/coder has gone missing.

  • mglaman committed 061e53b on 8.x-1.x authored by czigor 
    Issue #2916512 by czigor: Paypal credit support
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

\o/ yay, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.