JsMinifierUnitTest::testMinifyJsqueeze() fails on Drupal CI with PHP 5.6 - but works fine with PHP 7.0 & 7.1.
The details being reported currently are not enough for me to figure out what's wrong with the code.
Patch attached to debug the issue. Test failure expected; probably for a few tries.

CommentFileSizeAuthor
#15 2916193-JsMinifierUnitTest-php5.6-15.patch19.32 KBnickdickinsonwilde
#14 2916193-JsMinifierUnitTest-php5.6-14.patch9.13 KBnickdickinsonwilde
#13 2916193-JsMinifierUnitTest-php5.6-13.patch6.21 KBnickdickinsonwilde
#11 2916193-JsMinifierUnitTest-php5.6-11.patch5.9 KBnickdickinsonwilde
#9 2916193-JsMinifierUnitTest-php5.6-9.patch5.86 KBnickdickinsonwilde
#8 2916193-JsMinifierUnitTest-php5.6-8.patch5.76 KBnickdickinsonwilde
#6 2916193-JsMinifierUnitTest-php5.6-6.patch1.44 KBnickdickinsonwilde
#4 2916193-JsMinifierUnitTest-php5.6-4.patch1.37 KBnickdickinsonwilde
#2 2916193-JsMinifierUnitTest-php5.6-2.patch819 bytesnickdickinsonwilde

Comments

NickWilde created an issue. See original summary.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-2.patch819 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2916193-JsMinifierUnitTest-php5.6-2.patch, failed testing. View results

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-4.patch1.37 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2916193-JsMinifierUnitTest-php5.6-4.patch, failed testing. View results

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-6.patch1.44 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2916193-JsMinifierUnitTest-php5.6-6.patch, failed testing. View results

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-8.patch5.76 KB

Interesting...

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-9.patch5.86 KB

Status: Needs review » Needs work

The last submitted patch, 9: 2916193-JsMinifierUnitTest-php5.6-9.patch, failed testing. View results

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-11.patch5.9 KB

Status: Needs review » Needs work

The last submitted patch, 11: 2916193-JsMinifierUnitTest-php5.6-11.patch, failed testing. View results

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-13.patch6.21 KB
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-14.patch9.13 KB
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
StatusFileSize
new 2916193-JsMinifierUnitTest-php5.6-15.patch19.32 KB

  • NickWilde committed 5cfe0e1 on 8.x-3.x 
    Issue #2916193 by NickWilde: JsMinifierUnitTest::testMinifyJsqueeze()...
nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Assigned: nickdickinsonwilde » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.