Drupal issue: https://www.drupal.org/node/2018075 resolves the issue where inline floats are delegated out to the media-container wrapper; however the class applied is not consistent with the class used if the alignment is set through the media browser. If the alignment is set inline the class is media-float-{position}. If it is set via the media browser the class is media-wysiwyg-align-{position}. This results in inconsistencies for themed output such as margins, padding, etc.
Include the media-wysiwyg-align-{position} for alignments set inline.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | media_inline_filter-2913361-7.patch | 597 bytes | adam-delaney |
| Screen Shot 2017-10-02 at 2.34.19 PM.png | 28.58 KB | adam-delaney | |
| Screen Shot 2017-10-02 at 2.34.09 PM.png | 931.77 KB | adam-delaney |
Comments
Comment #2
adam-delaney commentedUpdating version for the version I'm testing with.
Comment #3
joseph.olstadwhat base theme are you using?
is it bootstrap?
or other?
Comment #4
joseph.olstadComment #5
adam-delaney commentedI am using Radix, however I have been able to replicate the issue using Bartik. I don't see any preprocessing of classes within any modules that I am using that would modify the default class implemented by media_browser. The CSS is being called from
media/modules/media_wysiwyg/css/media_wysiwyg.base.css, i.e..media-wysiwyg-align-left { }, which means it is agnostic from any theme styles.Comment #6
joseph.olstadok, so if you propose a css adjustment for this, a patch could be made from that and thus reviewed.
Comment #7
adam-delaney commentedHere's a patch that adds the midea-float-{position} selector to the corresponding css declarations in media_wysiwyg.base.css.
Comment #8
adam-delaney commentedComment #11
joseph.olstad