Currently, counter does not updated, when user press Up/Down vote (thumbs widget checked). I add this functionality to module. Also, new functionality work when you have several widgets on page (for example, inside view). Also, throbber image URL fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | vote_up_down.5.patch | 3.91 KB | jeffdavidgordon |
| #9 | vote_up_down.4.patch | 3.77 KB | andrew answer |
| #7 | vote_up_down.4.patch | 4.17 KB | andrew answer |
| vote_up_down.patch | 3.65 KB | andrew answer |
Comments
Comment #2
andrew answer commentedComment #5
marvil07 commentedThanks for the patch! I cannot test right now, but it looks OK, so I have just added it for now to 8.x-1.x.
Comment #6
andrew answer commentedPlease check widgets other than "thumbs", I don't check it.
Comment #7
andrew answer commented@marvil07, I update a patch with check - when user never vote before, no 'uservote' array exist.
Comment #8
andrew answer commentedComment #9
andrew answer commentedPaths fixed.
Comment #13
marvil07 commentedFirst, thanks for the new patches!
Indeed, there was a problem as reported on #2921126: Vote is not working anymore since the latest release.
I decided to revert the original commit for now.
I still need to try the latest patch, but from reviewing it, I would suggest to:
Avoid making an absolute URL for the throbber, make it a relative path instead.
The entity* variables should be already defined, so it should not be extracted from
routeUrl.I may be wrong, but this may a be a bug on the php side not passing the right variables when the entity is not yet created, and should be fixed there to get the values form the field settings if the entity is not yet created.
Comment #14
jeffdavidgordon commentedJust re-rolling #9 so that it works with alpha4 and latest dev code
Comment #15
marvil07 commented@jeffdavidgordon: Is this still relevant after #2906057: Use drupal core ajax api?
Comment #16
jeffdavidgordon commentedSorry for taking so long to get back to you, I can confirm that this patch is no longer needed for what's in the latest commit in 8.x-1.x branch.
Comment #17
marvil07 commented@jeffdavidgordon: thanks for the confirmation!