Problem/Motivation

IMHO users don't care where the files are relative to drupal, they just want to be able to use the image

            "meta": {
                "derivatives": {
                    "recipe_list_350_300": "/sites/default/files/styles/recipe_list_350_300/https/www.cookipedia.co.uk/wiki/images/a/ab/Jamies_4_hour_lamb_lamb_shanks.jpg?itok=_3CmMqyB",
                    "recipe_detail_750_550": "/sites/default/files/styles/recipe_detail_750_550/https/www.cookipedia.co.uk/wiki/images/a/ab/Jamies_4_hour_lamb_lamb_shanks.jpg?itok=tK9pG_LQ"
                }
            }

Proposed resolution

Use absolute URLs

Remaining tasks

User interface changes

API changes

Data model changes

Comments

dawehner created an issue. See original summary.

dawehner’s picture

Status: Active » Needs review
StatusFileSize
new1.82 KB

Note: This patch doesn't work yet ...

Status: Needs review » Needs work

The last submitted patch, 2: 2911330-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new1.66 KB
new1.76 KB

There we go ...

e0ipso’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Vienna2017

This patch breaks BC. Let's make sure it's worth it.

  • e0ipso committed 1bcc009 on 8.x-1.x authored by dawehner
    feat(DX): Absolute URLs (#2911330 by dawehner)
    
dawehner’s picture

Maybe that's indeed something for version 2 of the module? By using file_create_url you would theoretical enable CDN support for example.

e0ipso’s picture

@dawehner version 2 is released. Version 1 is now deprecated. Let's be agile!

dawehner’s picture

Embrace the version control

e0ipso’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.