Optimizations and fixes

Hi, I've also find the $account->{$fields[0]['name']} bug, but I've thinked out much simpler fix. Only change the line 133 to this: if (!isset($account->{key($fields)}))

There is no need to have the $user as a static variable actually for this reason. I think when we store realname in the $account object, we don't need to store realname in the static array $user[uid]. I will make a try what and how exactly Drupal caches accounts. When Drupal load one node (& user author account w/ profile) and then use the account in other case (i.e. second node). If the Drupal loads the user profile twice, it will be the reason for static caching :-)

function realname_make_name(&$account) {
  $fields = variable_get('realname_fields', array());
  $pattern = variable_get('realname_pattern', ' ');

  // Has the profile been loaded?
  //if (!isset($account->{$fields[0]['name']})) {
  // ^^ this produced lots of notices (15 actually on the page mysite.com/user/1)
  // notice: Undefined offset: 0 in D:\workspace\...\realname.module on line 133.
  // error_reporting(E_ALL); ini_set('display_errors', 'On'); This is very usefull for bug catching ...
  if (!isset($account->{key($fields)})) {
    profile_load_profile($account);
  }

   ... etc

andypost your patch causes one unwanted thing. The line "$account->name = $account->realname;" in hook_user causes that username on user edit form (user/%/edit) is now realname.

If we want to keep this feature, we need to fix the form in the hook_form_alter. This hook is already implemented so we only add one "case" ~ three lines of code.

/**
 * Implementation of hook_form_alter().
 * Intercepts the contact forms to show the realname.
 */
function realname_form_alter(&$form, $form_state, $form_id) {
  global $user;
  
  switch ($form_id) {
    // FIX for $account->name
    case 'user_profile_form':
      $form['account']['name']['#default_value'] = $form['_account']['#value']->realname_save;
      break;
    case 'contact_mail_user':

   ... etc

If you indeed apply the fix for $account->name, you will need to make sure that $account->realname_save actually contains the correct data. The following code prevents $account->realname_save from using an already modified $account->realname in hook_user.

<?php
if (!isset($account->realname_save))
      {
      $account->realname_save = $account->name;
      $account->name = $account->realname;
      }
?>

Correction: that code causes errors pertaining to the objects when someone attempts to sign up. This code fixes that issue, at least in all my tests.

<?php
if (!isset($account->realname_save) && is_object($account))
      {
      $account->realname_save = $account->name;
      $account->name = $account->realname;
      }
?>

Can one of you roll an actual patch, please? There are instructions on the project page on how to become a co-maintainer.

A patch would be great.

Here's the patch for what I believe are all the changes. Works as it should on my own site.

Committed on both branches.

Thanks. Hopefully I can do this before the end of the weekend. I have places to go right now.

Committed to both branches.

I am reactivating this because the realname_save workaround is causing some side-effects in other modules.

This is realname code:

case 'user_profile_form':
      if (variable_get('realname_theme', TRUE)) {
        $form['account']['name']['#default_value'] = $form['_account']['#value']->realname_save;
      }
      break;

However according to http://api.drupal.org/api/function/user_edit_form/6 this is how Core prepares the field:

if ($register || ($GLOBALS['user']->uid == $uid && user_access('change own username')) || $admin) {
    $form['account']['name'] = array('#type' => 'textfield',
      '#title' => t('Username'),
      '#default_value' => $edit['name'],
      '#maxlength' => USERNAME_MAX_LENGTH,
      '#description' => t('Spaces are allowed; punctuation is not allowed except for periods, hyphens, and underscores.'),
      '#required' => TRUE,
    );
  }

Notice that if the user does not have permissions to change own username then the field is not present in $form at all. Now code in RealName doesn't check permissions or the field's existance and create such entries:

    ["name"]=>
    array(1) {
      ["#default_value"]=>
      string(18) "memfis"
    }

When other modules test for name field existance like RealName should, they are fooled by this and start some processing which leads to unexpected results. This happens with the UserProtect module.

I would suggest to change RealName code this way (added check for name field):

    case 'user_profile_form':
      if (variable_get('realname_theme', TRUE) && isset($form['account']['name'])) {
        $form['account']['name']['#default_value'] = $form['_account']['#value']->realname_save;
      }
      break;

This solves the issue with UserProtect and potentially other modules.