Closed (fixed)
Project:
Dialogflow (Api.AI) Webhook
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Sep 2017 at 03:18 UTC
Updated:
25 Sep 2017 at 12:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
larowlanSomething like this
Comment #3
gambryThat's cool. I've just changed 2 minor things:
We don't need these two? Unless there is something I'm missing.
We need this until is #2905388: The "view" entity type does not exist in. :(
For the point above, I guess node can go.
If patch is ok for you I'll commit!
Comment #4
larowlanBot is reporting no tests found? Changes look good
Comment #5
gambryWeird. I had the same issue locally, it only worked by passing to phpunit the path to the module.
I'll investigate.
Comment #6
gambryThis is happening:
And I don't see any line about pulling test dependency
chatbot_api. Wondering if new test_dependencies declaration is ignored if coming from a patch?Shall we put this in and see if re-testing the 8.x-1.x branch runs the test?
Comment #7
gambryI had a chat with @dawehner and he thinks #6 is likely to be the reason why test doesn't run.
He mentioned a release with
chatbot_apias info.yml test_dependencies and composer dev-dependencies should fix the problem.To me it looks like too much work for a test passing locally, so if you don't see any problem I suggest to commit this and see if test run against the branch.
Comment #8
larowlanYeah agree
Comment #10
gambryThis is in now. Let's see if next test against branch is OK.
Thanks!