Problem/Motivation

This global defined before version check

/**
 * Global flag to indicate the site is in installation mode.
 *
 * The constant is defined using define() instead of const so that PHP
 * versions prior to 5.3 can display proper PHP requirements instead of causing
 * a fatal error.
 */
define('MAINTENANCE_MODE', 'install');

Proposed resolution

Move to install_drupal() cos here installation really begins and mode changing
TODO find better class constant #1530756: [meta] Use a proper kernel for the installer

Remaining tasks

Discus, Patch, Commit

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#21 2906787-21.patch1.11 KBmaks oleksyuk
#13 2906787-13.patch1.98 KBsharma.amitt16
#4 2906787-move_definition_of_mm_mode.patch1.34 KBmariiadeny

Issue fork drupal-2906787

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 2906787 Comparechanges, plain diff MR !7913
  • 11.x Comparecompare
About issue forks

Comments

andypost created an issue. See original summary.

gumanist’s picture

gumanist commented
Title: Move definistion of MAINTENANCE_MODE = install to install_drupal » Move definition of MAINTENANCE_MODE = install to install_drupal
Issue summary: View changes
gumanist’s picture

gumanist commented
mariiadeny’s picture

mariiadeny commented
StatusFileSize
new 2906787-move_definition_of_mm_mode.patch1.34 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 2906787-move_definition_of_mm_mode.patch, failed testing. View results

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2908079: Move some of the bootstrap.inc PHP-related constants to \Drupal and deprecate the old versions
sharma.amitt16’s picture

sharma.amitt16 commented
Status: Needs work » Needs review
StatusFileSize
new 2906787-13.patch1.98 KB

Re-rolling the patch for the D9.1.x branch.

Status: Needs review » Needs work

The last submitted patch, 13: 2906787-13.patch, failed testing. View results

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

maks oleksyuk’s picture

maks oleksyuk commented
Status: Needs work » Needs review
StatusFileSize
new 2906787-21.patch1.11 KB

Updating the patch to branch 11.x

Status: Needs review » Needs work

The last submitted patch, 21: 2906787-21.patch, failed testing. View results

Maks Oleksyuk opened merge request !7913

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.