Allow to override the drupal user registration settings while logging in via openid

Thanks for the patch, I'm in a similar case: don't allow any manual user registration, but do allow OpenID Connect users.

The patch works fine. I do have some remarks:

• The comment "// Check if we are..." exceed 80 chars and should be split up on 2 lines
• The else statement should start on a new line "} else {"
• I don't see any test for the new registration method, only SettingsFormTest that uses the config value. It might need the extra value.
• You are adding a value to the setting config. The default config is set via the patch, but you should also update the active config, f.e. :
  

  /**
   * Update the active config with the registration override value.
   */
  function openid_connect_update_8102() {
    $config_factory = \Drupal::configFactory();
    $config = $config_factory->getEditable('openid_connect.settings');
    $config->set('override_registration_settings', FALSE);
    $config->save();
  }
  

@interX you can find a patch for this feature over in #2867260: Add pre_login hook similar to post_authorize hook (D8 version) :)

I think this patch is a more elegant way to simply override the registration setting and continue the path in the OpenID Connect module.
A pre_login hook could be useful, but imo it shouldn't be used as in the linked example (specifically create an authmap for the account manually).

Sorry for the confusion, the patch over in the other issue is handy if you e.g. migrate users beforehand but in your case you want to allow registrations via OpenID Connect but not via /user/register – sorry 😬

/nitpickmodus on :)

Normally the comment:

    // Check if we are allowing to create users overriding
    // the drupal user register settings:

should continue on one line until a word reaches the 80 characters limit, and then go to the next line.
Also, Drupal should always start with a capital. So, it should be:

    // Check if we are allowing to create users overriding the Drupal user
    // register settings:

/nitpickmodus off

* Changed the code to only respect override in case admin only is set for user registration.
* Changed order of form elements
* Some code style fixes
* Syntax error fix

Thanks for the patch!

What if user settings has Visitors, but administrator approval is required.
Currently I have this requirement.

What if user settings has Visitors, but administrator approval is required.
Currently I have this requirement.