Problem/Motivation

Currently there is no normalizer for viewsreference so null gets returned. In order to have proper json view returned a Normalizer needs to be created.

Proposed resolution

Create a normalizer for '\Drupal\viewsreference\Plugin\Field\FieldType\ViewsReferenceItem'

Remaining tasks

  • Add validation
  • Add documentation
  • Add tests

I have included a patch for the base of the normalizer

CommentFileSizeAuthor
#3 2900315-3-normalizer.patch1.42 KBbojan_dev
viewsreference.patch1.62 KBnylsoo

Comments

Nylsoo created an issue. See original summary.

idebr’s picture

idebr commented

Closed #2913557: Provide normalizer/serializer support for the field type as a duplicate.

bojan_dev’s picture

bojan_dev commented
StatusFileSize
new 2900315-3-normalizer.patch1.42 KB

Normalization was already working for the ViewsReferenceItem due it's parent EntityReferenceItem, the only thing that wasn't yet working was the denormalizer, it was only setting the target_id value and was missing the additional viewsreference properties (display_id and data). So by just returning all the properties in the constructValue we are good to go.

ralphvdhoudt’s picture

ralphvdhoudt commented
Status: Needs review » Reviewed & tested by the community

The patch works as advertised

  • seanB committed 22af4e9 on 8.x-2.x authored by bojan_dev 
    Issue #2900315 by NielsOtten, bojan_dev, ralphvdhoudt, seanB: Normalizer...
seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented

Looks good, thanks! Committed and will roll a new release soon.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Reviewed & tested by the community » Fixed
jberube’s picture

jberube commented

I just upgraded from alpha4 to alpha5, and I get fatal error on any page, or on a cache clear.

>drush cr

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 31:

  The service "serializer" has a dependency on a non-existent service "hal.link_manager".

or if I do updb:

>drush updb

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 31:

  The service "serializer" has a dependency on a non-existent service "viewsreference.normalizer.views_reference_item.hal".
reevo’s picture

reevo commented

@jberube, see related issue for workarounds: #3096956: Updating from alpha4 to alpha5 via composer results in error

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.