Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Various settings for this module are currently dependent of each other:
1) The favicon setting will only currently be applied if the toolbar integration is enabled too.
2) The environment indicator logic currently tries to apply when the name setting for the active environment is empty, which currently comes out looking wrong (the top-level toolbar icon gets misaligned, and an oddly-thin empty coloured bar shows when there is no toolbar).
I think the module logic should be dependent on the environment name. That allows for the module to be enabled across multiple environments, but if one of the environments doesn't have a name, then the indicator(s) could not show. (This avoids having to set up configuration splits, for example.)
But I think it should be possible to alter the favicon without integrating with the toolbar, or the toolbar without altering the favicon.
Patch to follow :-)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | interdiff-2895676-2-3.txt | 1.91 KB | james.williams |
| #3 | environment-indicator-independent-settings-2895676-3.patch | 4.04 KB | james.williams |
Comments
Comment #2
james.williams CreditAttribution: james.williams at ComputerMinds commentedPatch, as promised :-) This does the following:
1) Avoids applying any changes when the environment name is empty.
2) Allows the favicon & toolbar settings to be independently enabled.
I realise these two things could be handled as separate issues, but they are pretty inter-related, so any patch for either would conflict with the other.
Comment #3
james.williams CreditAttribution: james.williams at ComputerMinds commentedSorry that last one can produce a javascript error when the favicon setting is enabled, but without a name being set. (Which is a good example of how the settings were previously interdependent when they didn't need to be!) In that scenario with this newer patch, the favicon can now still show a coloured 'tinycon', but without a letter (and no JS error!).
Comment #4
e0ipso