Problem/Motivation

Drupal\tmgmt_acclaro\Plugin\tmgmt\Translator\AcclaroTranslator::importTranslation() does not explicitly set status to translated for received translations. The status change work in most of the cases except when a job item was in TMGMT_DATA_ITEM_STATE_PRELIMINARY state:

* @param int|null $status
* (Optional) The data item status that will be set. Defaults to NULL,
* which means that it will be set to translated unless it was previously
* set to preliminary, then it will keep that state.
* Explicitly pass TMGMT_DATA_ITEM_STATE_TRANSLATED or
* TMGMT_DATA_ITEM_STATE_PRELIMINARY to set it to that value.
* Other statuses are not supported.

Proposed resolution

Explicitly set TMGMT_DATA_ITEM_STATE_TRANSLATED status when importing remote translation.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 explicitly_set-2892931-2.patch803 bytesmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

Status: Active » Needs review
StatusFileSize
new803 bytes

Implemented suggested solution.

  • Berdir committed 72f9a30 on 8.x-1.x authored by mbovan
    Issue #2892931 by mbovan: Explicitly set translated status for completed...
berdir’s picture

Status: Needs review » Fixed

Makes sense, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.