As part of the TLS requirements that Braintree and PayPal are forcing, we should update the module to depend on the 3.x version of the Braintree PHP SDK. 3.21.0 specifically with ensure that transactions are made using TLS 1.2 at a minimum.

CommentFileSizeAuthor
#4 add_support_for_3_x_sdk-2887415-4.patch15.09 KBmglaman
#4 interdiff-2887415-2-4.txt2.18 KBmglaman
#2 commerce_braintree-add_support_for_3x_sdk-2887415.patch14.28 KBandyg5000

Comments

andyg5000 created an issue. See original summary.

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Active » Needs review
StatusFileSize
new commerce_braintree-add_support_for_3x_sdk-2887415.patch14.28 KB
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work 
Notice: Trying to get property of non-object in commerce_braintree_js_process_transaction() (line 939 of /var/platform/www/sites/all/modules/commerce_braintree/commerce_braintree.module).
Notice: Trying to get property of non-object in commerce_braintree_js_process_transaction() (line 940 of /var/platform/www/sites/all/modules/commerce_braintree/commerce_braintree.module).
Your payment transaction could not be processed at this time. If an error was provided it was: Credit card number is not an accepted test number.

Doesn't seem to handle errors well.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2887415-2-4.txt2.18 KB
new add_support_for_3_x_sdk-2887415-4.patch15.09 KB

I guess that bug was always hanging around. This checks if the response object is an Error or not.

  • andyg5000 committed 03ff64e on 7.x-2.x 
    Issue #2887415 by mglaman, andyg5000: Add support for 3.x SDK
andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.