Issue Description

The variable $entity_id is never defined on line 88 in /recurly/modules/recurlyjs/src/Form/RecurlyJsSubscribeForm.php

As a result, the account code is always 'user-' which causes issues with multiple account creation via the Subscribe form.
$recurly_account->account_code = $entity_type . '-' . $entity_id;

Solution/Patch

A simple patch replacing $entity_id with $entity->id() should resolve this issue.

CommentFileSizeAuthor
#3 entity_id_variable_undefined-2886639-2.patch691 bytesutsavjshah

Comments

utsavjshah created an issue. See original summary.

utsavjshah’s picture

utsavjshah commented
Version: 8.x-1.0 » 8.x-1.x-dev
utsavjshah’s picture

utsavjshah commented
StatusFileSize
new entity_id_variable_undefined-2886639-2.patch691 bytes
markdorison’s picture

markdorison
he/him
commented
Status: Active » Needs review
markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

markdorison’s picture

markdorison
he/him
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.