The user can submit the field settings form without choosing any content type.

CommentFileSizeAuthor
#10 select_at_least_one-2881996-10-8.x-2.x.patch11.41 KBjibran
#10 select_at_least_one-2881996-10.patch12.42 KBjibran
#10 interdiff-4f05d7.txt2.07 KBjibran
#10 interdiff-e8fd64.txt2.13 KBjibran
#6 at_lest_select_one-2881996-6-8.x-1.x.patch12.42 KBjibran
#6 at_lest_select_one-2881996-6-8.x-1.x-test-only.patch10.57 KBjibran
#6 interdiff-b924fb.txt3.76 KBjibran
#5 at_lest_select_one-2881996-5-8.x-1.x.patch11.59 KBjibran
#5 at_lest_select_one-2881996-5.patch11.4 KBjibran
#5 at_lest_select_one-2881996-5-test-only.patch9.69 KBjibran
#5 interdiff-db9904.txt824 bytesjibran
#4 at_lest_select_one-2881996-4.patch11.37 KBjibran
#4 at_lest_select_one-2881996-4-test-only.patch9.66 KBjibran
#4 interdiff-5360fa.txt10.81 KBjibran
#2 at_lest_select_one-2881996-2.patch1.46 KBjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Needs tests
StatusFileSize
new at_lest_select_one-2881996-2.patch1.46 KB

Here is the patch for the fix. Just needs a test.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: -Needs tests
StatusFileSize
new interdiff-5360fa.txt10.81 KB
new at_lest_select_one-2881996-4-test-only.patch9.66 KB
new at_lest_select_one-2881996-4.patch11.37 KB

Tests++

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-db9904.txt824 bytes
new at_lest_select_one-2881996-5-test-only.patch9.69 KB
new at_lest_select_one-2881996-5.patch11.4 KB
new at_lest_select_one-2881996-5-8.x-1.x.patch11.59 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-b924fb.txt3.76 KB
new at_lest_select_one-2881996-6-8.x-1.x-test-only.patch10.57 KB
new at_lest_select_one-2881996-6-8.x-1.x.patch12.42 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Needs work 
+    $options = array_filter(array_keys($labels[(string) t('Content', [], ['context' => 'Entity type group'])]), function ($entity_type_id) {

Uggo.

+      $form_state->setError($element, t('At lest select one entity type ID.'));

Typo.

Theres also tests asserting this typo.

dpi’s picture

dpi
Location Perth, Australia
commented
Title: At lest select one entity type ID on field storage setting form » Select at least one entity type ID on field storage setting form
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-e8fd64.txt2.13 KB
new interdiff-4f05d7.txt2.07 KB
new select_at_least_one-2881996-10.patch12.42 KB
new select_at_least_one-2881996-10-8.x-2.x.patch11.41 KB

This happens when you make one typo and copy paste it everywhere. :D Thanks for the review.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Reviewed & tested by the community

:D

  • jibran committed 4225e98 on 8.x-2.x 
    Issue #2881996 by jibran, dpi: Select at least one entity type ID on...

  • jibran committed a65c821 on 8.x-1.x 
    Issue #2881996 by jibran, dpi: Select at least one entity type ID on...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.