Add support of variadic type hinting and argument specification

+1 to this!

Here's a temporary hack to disable this check on variadics. This isn't a good long-term solution, but it works for us to integrate PHPStan into our CI, where PHPStan wanted the correct type hint, but phpcs/coder was erroring on it.

There is still an error after applying the patch.

I created a new patch that:

• Detects if it has a variadic string in the parameter type (...).
• Counts the number of spaces between the parameter type and the variadic sign.
• Removes the spaces and variadic sign from the parameter type string.

This allows the rest of the checks to further validate the parameter type annotation.

Patch from #5 had done the trick for us! It removed the false negative (error saying 1 space was expected, but 0 found), and correctly adds an error if there is more than one space.

Note that we are using named variadic parameter documentation as shown off in the OP (...$arguments, instead of just ...). However, this patch seems to be compatible with both formats, which is nice.

Good to hear and thanks for the manual testing!

Next steps here are to create a pull request against https://github.com/pfrenssen/coder and add a test case.

In the CiviCRM Community we have applied patch #5 to our version of coder and have confirmed it fixed the issue for us without any ill affects.

Updated patch for drupal/coder v8.3.12.

• Added example to tests.
• Pull request created (https://github.com/pfrenssen/coder/pull/137)

Merged, thanks!