We need to convert the module to use short array as per new coding standard

CommentFileSizeAuthor
#3 scroll_to_element_array_search_results.png38.07 KBdhruveshdtripathi
#2 2877190-2.patch1.27 KBPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Status: Active » Needs review
StatusFileSize
new 2877190-2.patch1.27 KB

Applying the patch, please review

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new scroll_to_element_array_search_results.png38.07 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier here were 3 array declarations, after applying patch there are 0.

Good work!

  • Gertjan.k committed 744eb67 on 8.x-1.x authored by Pavan B S 
    Issue #2877190 by Pavan B S, dhruveshdtripathi: Convert module to use...
Gertjan.k’s picture

Gertjan.k commented
Status: Reviewed & tested by the community » Fixed

Thanks for your work! Commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.