Remove scaffolded csslint and eslint config

Drupal core has a few different places to look for .[something]rc files.

In DRUPAL_ROOT we have:

.csslintrc
.eslintignore
.eslintrc.json

In DRUPAL_ROOT/core we have:

.eslintignore
.eslintrc.json
.eslintrc.legacy.json
.stylelintrc.json

Do we have related issues to deal with eslint config?

.stylelintrc.json seems to be setting a pattern that this sort of config file will be in core/.

From a drupalci standpoint, it makes the most sense to have these dotfiles (and, for instance, package.json) in core/. That's fewer use-cases per tool.

Also, if core doesn't support the csslint tool, it's hard to make a case for supporting it in the testbot.

I faced few days ago with issue in CI when theme (zen based) failed to build because it was not inside of Drupal.
That caused by http://eslint.org/docs/user-guide/configuring#configuration-cascading-an...

By default, ESLint will look for configuration files in all parent folders up to the root directory.

So removal of config files from root can cause a storm of failures

@andypost could we remove it in a minor version with a change record for people to add it back in?

@joelpittet sure it just needs change record

I opened an issue to disable CSSLint in the Drupal core DrupalCI builds: #3166360: Disable csslint testing in core. After that, next step is to decide how to remove the file.

As related commited the removal is straight

Reviving this after rediscovering these config files in #3440225: Update to ESLint v9 with standard rules

Given that there has been no activity here for 5 years and CSSLint is obsolete I think we should definitely drop the csslintrc file.

I also think we should do the same for the ESLint config files. Sites can still choose to extend core's configuration if they want to, but I suspect that almost all sites have their own package.json and lint config, be it across an entire project or at the theme or module level. We don't need to be opinionated here on their behalf.

I think we should definitely drop the csslintrc file.
I also think we should do the same for the ESLint config files.

Just wondering if core/.eslintrc.passing.json and core/.eslintrc.jquery.json the files you are refering to? These are used in Contrib testing via Gitlab Templates

No, but those are going to have to change when we upgrade to ESLint 9, as the config file format has changed. Discussion of that is welcome over in #3440225: Update to ESLint v9 with standard rules as we will need to coordinate with the contrib CI templates over there.

I am referring to the files in assets/scaffold/files, which are scaffolded to the root of all Drupal installs via the scaffold plugin in composer.json.

Let's repurpose this issue a bit and get the ball rolling.

Let's try to get some signoffs on this.

Personally I think that if you are using ESLint it is up to you to configure it; we don't provide a scaffolded package.json so you would need to manually install the correct set of plugins anyway to make the configuration work if you are using this - I just can't see that anyone is actually using these files in a real site.

Rewrote the IS with the latest proposal.

Created #3559584: Move some scaffolding files for linting jobs from core to the assets folder for Contrib CI.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

This one would need a rebase but it would be really nice to get this into main so we can work in it for a few months before 12.x is cut.

IS needs update as tags, csslint is obsolete but jslint is not clear, needs CR and release notes as #5

Added this to the 'other' section of #3449808: [12.x] [meta] Requirements for tagging 12.0.0-beta1

@quietone, @godotislate, and I all agreed on making this change, and since @longwave made the MR his support is implicit as well.

What a happy MR with happy red lines everywhere!

This is probably a bug report now, because since #3440225: Update to ESLint v9 with standard rules the scaffolded ESLint config doesn't work; bumping to major because of this. The csslint config is also dead, so I think this should just all be removed.

Added a CR: https://www.drupal.org/node/3621537

That's ok with me, always been a pain to make use of core rules on projects, and folks usually set that at the theme level anyway. Not quite sure on all the scaffold changes so won't RTBC.

lgtm

"any sites I have worked on have their own linting config in the theme or the root of the repo."

I mean, we have to since core's was basically impossible to use for several years now waiting on #3440225: Update to ESLint v9 with standard rules. But I was following this thread of issues to hopefully fix that so... is the expectation that sites following core style/lint rules for custom development would pull from Gitlab templates too? Or would they be responsible for manually syncing changes with Core? Or just on their own and can't really follow core like we can for other tools?

Core's rules are still shipped inside the core directory so I think you should be able to refer to those. Documenting how to reuse the config, or making it work in the contrib templates, would be useful if someone can do that, but I think it's separate to this issue even if it is adjacent to it.

The only change here is the removal of the files scaffolded into the root directory of sites.

Committed/pushed to main, thanks!