Drupal::l() / Link::fromTextAndUrl $text documented as string, actually accepts string|array|\Drupal\Component\Render\MarkupInterface

Needs updating for 9.1.x. Note that l() was removed in 9.0.0:

https://www.drupal.org/project/drupal/issues/2606376

Updating @param documentation for Drupal\Core\Link::fromTextAndUrl() only for 9.1.x as l() was removed in 9.0.0. Kindly review a patch.

Thanks for the update. I see that it addresses #10.

Looking at LinkGeneratorInterface, it has this description:

   * @param string|array|\Drupal\Component\Render\MarkupInterface $text
   *   The link text for the anchor tag as a translated string or render array.
   *   Strings will be sanitized automatically. If you need to output HTML in
   *   the link text, use a render array or an already sanitized string such as
   *   the output of \Drupal\Component\Utility\Xss::filter() or
   *   \Drupal\Component\Utility\SafeMarkup::format().

and the patch here has:

+++ b/core/lib/Drupal/Core/Link.php
@@ -47,8 +47,8 @@ public function __construct($text, Url $url) {
-   * @param string $text
-   *   The text of the link.
+   * @param string|array|\Drupal\Component\Render\MarkupInterface $text
+   *   The link text for the anchor tag as a translated string or render array.

So it does not include this part:

   *   Strings will be sanitized automatically. If you need to output HTML in
   *   the link text, use a render array or an already sanitized string such as
   *   the output of \Drupal\Component\Utility\Xss::filter() or
   *   \Drupal\Component\Utility\SafeMarkup::format().

but perhaps this is ok since it's documented in the LinkGeneratorInterface.

Given that and tests are green, marking this RTBC.

Committed 1671837 and pushed to 9.1.x. Thanks!

Cherry-picked to 9.0.x

This needs updating for 8.9.x to make the same change to \Drupal::l() (which doesn't exist in 9.x)

Thanks for the patch. Looks good to me.

1) Patch applies cleanly.

2) Tests pass.

3) Updates Drupal::l() and Link::fromTextAndUrl() as expected and the text is identical in both places and matches what was used in 9.0.x/9.1.x.

C/p to 8.9.x - thanks