Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The latest embed code uses a script tag that when run adds the iframe with span wrappers. See attached
vidyard_embed-latest-20170504.png.
Currently, this module embeds using the legacy iframe. See attached vidyard_embed-legacy-iframe-20170504.png .
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | video_embed_vidyard-new-embed-code-2875794-3.patch | 1.99 KB | eric115 |
| #2 | video_embed_vidyard-new-embed-code-2875794-2.patch | 2.11 KB | recrit |
| vidyard_embed-legacy-iframe-20170504.png | 136.18 KB | recrit | |
| vidyard_embed-latest-20170504.png | 64.4 KB | recrit |
Comments
Comment #2
recrit commentedThe patch attached
* Updates the video embed markup to use the script tag per Vidyard.
* Adds CSS for responsive videos per http://knowledge.vidyard.com/33007-publish-your-player/245140-make-an-in....
Comment #3
eric115 commentedThanks for the patch, code looks good. This patch fixes up some minor indenting issues in the CSS file and removes the commented out properties.
I thought about adding an option to continue to render the embeds in the current fashion in case it breaks any styles for someone, but given the low number of 8.x users and the relatively similar markup, it's probably not necessary.
Comment #5
eric115 commentedComment #7
drup16 commentedIs any portion of this RTBC? This looks like it is not in the latest RC1 release.
Comment #8
eric115 commentedHi drupi17, this has been committed to the dev branch. I'll be rolling a new release, which will include this patch, sometime later today as part of https://www.drupal.org/project/magnific_popup/issues/2929016