Replaced deprecated functions like REQUEST_TIME, db_update.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 2875101-11.patch | 1.91 KB | saphemmy |
| #2 | Replaced_deprecated_functions-2875101-2.patch | 1.73 KB | Munavijayalakshmi |
Issue fork google_image_sitemap-2875101
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Munavijayalakshmi commentedComment #3
vaibhavjainCan you use the Inject DB object for any Database related stuff in this class.
Comment #4
saphemmy commentedWill work on this.
Comment #6
saphemmy commentedComment #7
tmaiochi commentedI'll review this!
Comment #8
tmaiochi commentedSteps performed:
(1) Installed module
(2) Reproduced the issue.
(3) Applied patch.
(4) Code review on changes.
(5) Tested again with patch, issue resolved.
The commit removed all deprecated code in this module, and the module still working well as far as I can test it.
Comment #9
vaibhavjainHi,
Please see if you can improve the patch.
Can you please try to use Dependency Injection for DB.
Same here.
Same here.
Comment #10
saphemmy commentedComment #11
saphemmy commented1.) This is already fixed in the latest version:
2.) Here is the patch for the dependency injection fix for points 2&3
Comment #12
tmaiochi commentedI'll review this!
Comment #13
tmaiochi commentedI've just added the patch in MR, by the way the patch added dependency injection correctly. How was said in #11 This is already fixed in the latest version:
Moving it to RTBC!
Comment #14
vaibhavjainThanks for the PR, it has been merged.
Comment #15
vaibhavjain