Do you plan to publish a drupal 8 version of this module?

Comments

Anonymous’s picture

joeking60 created an issue. See original summary.

khoomy’s picture

Hi joeking60

Yes I have plan to port into D8 but not started yet. Will start work D8 version soon.

Khoomy

w01f’s picture

Also very interested in this module!

Anonymous’s picture

I'm also waiting for a drupal 8 version of this module? Thanks.

leevh’s picture

Hi khoomy, I've made a d8 port of your module here: https://github.com/leevh/simple_image_rotate

Hope this helps, thanks for the handy module!

khoomy’s picture

Hi leevh

Thanks for the D8 port, I will look into this and will create D8 branch after testing.

I will add you in the credit list. :)

Khoomy

w01f’s picture

Wondering 2 things!

- Has the d8 version been tested yet, would additional assistance in testing the d8 port help to get a branch out?

- Does this module change the exif value to permanently make the orientation change, or does it add an additional instruction to rotate the image after the exif rotation info is applied?

stebentje’s picture

Drupal 8 module is working perfectly for me! Thanks

Atuan’s picture

#5 Works great. Thank you very much, leevh

sitiveni’s picture

Hi there.

In order to avoid Call to undefined method BaseFieldDefinition::getThirdPartySettings() you want to make sure you're calling getThirdPartySetting() only on config fields (objects of type ThirdPartySettingsInterface).

This is in function simple_image_rotate_rotate_image():

if ($field instanceof ThirdPartySettingsInterface) {
  if ($field->getThirdPartySetting('simple_image_rotate', 'enable_rotate') == 1) {
    ...

Also don't forget to set the use at the top of the .module file:

use Drupal\Core\Config\Entity\ThirdPartySettingsInterface;
ipwa’s picture

#5 works for me!

khoomy’s picture

Version: 7.x-2.0 » 8.x-1.x-dev
Status: Active » Fixed

Many thanks leevh for the D8 port of this project. :)
I have pushed the dev and alpha release 8.x-1.0-alpha1. Also added leevh as maintainer the this project. Much appreciated.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.