Follow-up to #2855775: Created help section

+++ b/chosen.module
@@ -16,6 +16,20 @@ define('CHOSEN_INCLUDE_NO_ADMIN', 1);
+      $output .= '<p>' . t('Configure at: <a target="_blank" href="@structure_types">admin/config/user-interface/chosen</a>', array('@structure_types' => base_path() . 'admin/config/user-interface/chosen')) . '</p>';

What is this? We have url() for this. Do not use base_path() here, please. We also do not use target.

CommentFileSizeAuthor
#2 fix-url-in-help-2864119-2.patch837 bytesnagy.balint

Comments

hass created an issue. See original summary.

nagy.balint’s picture

nagy.balint commented
Status: Active » Needs review
StatusFileSize
new fix-url-in-help-2864119-2.patch837 bytes
hass’s picture

hass commented
Status: Needs review » Reviewed & tested by the community
nagy.balint’s picture

nagy.balint commented

  • nagy.balint committed f6f5eb6 on 7.x-2.x 
    Issue #2864119 by nagy.balint, hass: Created help section - fixed url...
nagy.balint’s picture

nagy.balint commented
Status: Reviewed & tested by the community » Fixed

  • nagy.balint committed 7bcacf0 on 8.x-2.x 
    Issue #2864119 by nagy.balint, hass: Created help section - fixed url...
nagy.balint’s picture

nagy.balint commented
Version: 7.x-2.x-dev » 8.x-2.x-dev

Same in 8.x, fixed.

hass’s picture

hass commented
Status: Fixed » Needs work

That is incorrect for D8. The placeholders for URLs named :structure_types in opposite to @structure_types in D7.

  • nagy.balint committed 7dc86bc on 8.x-2.x 
    Issue #2864119 by nagy.balint, hass: Created help section - fixed url...
nagy.balint’s picture

nagy.balint commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.