When going to provide my provider settings in ad manager, under Slot-level customized targeting, my key value pair says array instead of the string value. This is cause because has chnage the way it interprets indirect expression. http://php.net/manual/en/migration70.incompatible.php
// Original expression
$entity->$entity_info['entity keys']['id'];
// PHP5: This is what we want.
$entity->{$entity_info['entity keys']['id']};
// PHP7: This is what we don't want.
($entity->$entity_info)['entity keys']['id']};
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2861162-php7-compatible-fix-02.patch | 1.96 KB | johnle |
Comments
Comment #2
johnle commentedHere is a patch that makes it compatible with PHP 7.
Comment #3
krisahil commentedI don't have a handy PHP 7 environment to test on. Waiting for someone else to review and test.
Comment #4
roberttstephens commentedI verified functionality of ads after this, and it fixed the 'array' in the slow level customized targeting. Setting to 'Reviewed & Tested by the community. @johnle, are you able to add this into 7.x-2.x?
Comment #6
krisahil commentedCommitted to 7.x-2.x branch.