This is a small follow-up issue for #2789839: Processing timeout admin settings.

In the module admin page, the timeout settings for queue processing can be configured. The units are seconds but are not apparent with the page.

I'd just like to add `(sec)` to the field labels. #field_suffix is good one to use to add the unit.

CommentFileSizeAuthor
#4 advancedqueue-cleanup-table-defined-var-fix-2854318-4.patch888 byteshgoto
#2 2858407-2-after.png83.47 KBhgoto
#2 2858407-2-before.png81.83 KBhgoto
#2 advancedqueue-add_timeout_unit_to_labels-2858407-2.patch1.49 KBhgoto

Comments

hgoto created an issue. See original summary.

hgoto’s picture

hgoto commented
Status: Active » Needs review
StatusFileSize
new advancedqueue-add_timeout_unit_to_labels-2858407-2.patch1.49 KB
new 2858407-2-before.png81.83 KB
new 2858407-2-after.png83.47 KB

Here's a patch.

maciej.zgadzaj’s picture

maciej.zgadzaj commented

Wouldn't it be better to put it in #field_suffix?

hgoto’s picture

hgoto commented
Issue summary: View changes
StatusFileSize
new advancedqueue-cleanup-table-defined-var-fix-2854318-4.patch888 bytes

Thank you, @maciej.zgadzaj. I didn't have an idea to use #field_suffix. Surely it's better.

Here is a new patch which introduces #field_suffix. This patch is simple and no interdiff is necessary, I think.

  • bojanz committed c3db6fc on 7.x-1.x authored by hgoto 
    Issue #2858407 by hgoto: The timeout units are not apparent from the...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

I went with "seconds" since "sec" is not an official abbreviation for seconds AFAIK, which would cause issues when translating.

Thanks!

hgoto’s picture

hgoto commented

@bojanz I see! thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.