Fix various instances of while entity labels and add while settings form

thx, the patch looks good - I've committed and pushed this one already. Leaving the issue open for the rest.

hm, I think we are doing this wrong. The entity-name should be in config, thus it should be translated via the config system. Once that's done, there should not be a need for the t() call.

>What I'm not sure about is the call to config translation in the alter hooks

I think this is fine. After while setting context changes, the entity type caches need to be cleared. Until there is no UI for that it's fine if one has to run a manual cache rebuild afterwards imo.

1. +++ b/src/Form/WhileMainConfigForm.php
   @@ -0,0 +1,100 @@
   + * Class WhileMainConfigForm.
   + *
   + * @package Drupal\ali_content_lifecycle\Form
   

   Comments need work.

2. +++ b/src/WhileEntityAccessControlHandler.php
   @@ -22,11 +22,9 @@ class WhileEntityAccessControlHandler extends EntityAccessControlHandler {
   -          return AccessResult::allowedIfHasPermission($account, 'view unpublished while entities')
   -            ->addCacheableDependency($entity);
   +          return AccessResult::allowedIfHasPermission($account, 'view unpublished while entities');
   

   Nope, that cache dependency has to stay.

3. +++ b/src/WhileEntityListBuilder.php
   @@ -64,7 +100,8 @@ class WhileEntityListBuilder extends EntityListBuilder {
   +    ¶
   

   whitespace

4. +++ b/white_label_entity.config_translation.yml
   @@ -0,0 +1,5 @@
   +white_label_entity.main_config_form:
   

   Would make sense to stay with consistent naming: Settings -> SettingsForm

5. +++ b/white_label_entity.routing.yml
   @@ -0,0 +1,9 @@
   +white_label_entity.main_config_form:
   

   as above, settings?

wrong issue

wrong issue

ok, I addressed the remaining issues and fixed the titles in the breadcrumbs of the collection routes.

And committed.