The help text is given but there is no proper information provided. Attaching the screenshot for the given help page.

Original screenshot

CommentFileSizeAuthor
#14 After patch.png71.19 KBmanojithape
#14 Before patch.png21.46 KBmanojithape
#11 serial-2857566-11.png162.96 KBcolorfield
#11 interdiff_8-11.txt2.86 KBcolorfield
#11 2857566-11.patch2.06 KBcolorfield
#9 serial-after-8.png75.22 KBalar
#8 help_text-2857566-8.patch1.55 KBaadil.addweb
#7 Screen Shot 2017-03-06 at 1.22.28 PM.png21.59 KBriddhi.addweb
#7 After patch.png71.09 KBriddhi.addweb
#5 serial_help_page.png49.31 KBdhruveshdtripathi
#4 help_text-2857566-4.patch1.51 KBaadil.addweb
#2 help-2857566-2.patch1.5 KBPavan B S
serialhellp.png8.42 KBPavan B S

Issue fork serial-2857566

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
StatusFileSize
new help-2857566-2.patch1.5 KB

Applying the patch, please review

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work

Thanks Pavan B S, for the patch but i have found one issue :-
Change Path from admin/content/types -> manage fields to admin/structure/types -> manage fields

aadil.addweb’s picture

aadil.addweb commented
Status: Needs work » Needs review
StatusFileSize
new help_text-2857566-4.patch1.51 KB

Please apply help_text-2857566-4.patch.

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new serial_help_page.png49.31 KB

Works well. Changing status to RTBC.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Reviewed & tested by the community » Needs work
riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new After patch.png71.09 KB
new Screen Shot 2017-03-06 at 1.22.28 PM.png21.59 KB

Hello @binoli.addweb,Thanks for the patch but i found 1 issue PFA.
Use the breadcrumb path instead of mentioned path in Help.

aadil.addweb’s picture

aadil.addweb commented
Status: Needs work » Needs review
StatusFileSize
new help_text-2857566-8.patch1.55 KB

Please apply the patch "help_text-2857566-8.patch" attached.

alar’s picture

alar commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new serial-after-8.png75.22 KB

Current patch (comment #8) resolves the original issue of incomplete help text. It also corrects the first patch issue that reported an incorrect file path.

after patch screen shot

alar’s picture

alar commented
Issue summary: View changes
colorfield’s picture

colorfield
Primary language French
Location Lausanne
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +DevDaysCluj
StatusFileSize
new 2857566-11.patch2.06 KB
new interdiff_8-11.txt2.86 KB
new serial-2857566-11.png162.96 KB

Patch 11

Serial help

rosinegrean’s picture

rosinegrean commented
Issue tags: -DevDaysCluj +DevDaysTransylvania
manojithape’s picture

manojithape commented
Assigned: Unassigned » manojithape
manojithape’s picture

manojithape commented
StatusFileSize
new Before patch.png21.46 KB
new After patch.png71.19 KB

Verified and tested patch#11. Patch applied successfully and looks good to me.

Testing Steps:

  1. Install Serial Field module
  2. Go to extend and Search "Serial" module and click on "help"
  3. Observe on the help page short help description displayed
  4. Apply patch and again go to the "Help" page
  5. Verify that on the help page proper descriptive description is displayed

Testing Results:
Proper descriptive help text displayed on the help page of the serial module.

Moving this ticket to RTBC.

manojithape’s picture

manojithape commented
Status: Needs review » Reviewed & tested by the community
manojithape’s picture

manojithape commented
Assigned: manojithape » Unassigned
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Version: 8.x-1.x-dev » 2.0.x-dev

The 8.x-1.x branch of this project is no longer active, but I think the patch will apply, with a minor change, to the 2.0.x branch.

benjifisher opened merge request !8

  • benjifisher committed 7e8d0325 on 2.0.x 
    Issue #2857566 by dev22.addweb, benjifisher, colorfield, Pavan B S,...
benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Reviewed & tested by the community » Fixed

I updated the patch for the 2.0.x branch and created a MR from it. Tests are passing.

Thanks to all who contributed to this issue. The new text is a big improvement!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.