We cannot push the 8.x-4.x branch forwards, or other modules that depend upon it, with failing tests. So lets fix the tests.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | panels-n2857369-5.patch | 2.28 KB | damienmckenna |
| #3 | panels-n2857369-3.patch | 2.28 KB | damienmckenna |
Issue fork panels-2857369
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
damienmckennaThe tests fail on d.o (https://www.drupal.org/pift-ci-job/611398) but they work locally. Gah.
Comment #3
damienmckennaThis renames the tests so the naming schemes are more consistent.
Comment #4
damienmckennaComment #5
damienmckennaWaking up testbot.
Comment #7
damienmckennaComment #10
liam morlandI created a merge request with the patch in #5. Some files no longer exist.
Comment #11
joelpittetThanks @liam morland, we need to get this in for a new release. I don't mind pushing up fixes here, but if you're working on it I don't want to step on your toes.
Comment #12
liam morlandI was just getting things started by putting the patch into a MR. I don't have any active work on this.
I don't think this is needed before a PHP 8.4 compatibility release.
Comment #13
joelpittetI don't like releases with broken pipelines... so I am going to sort it out, thanks for confirming.
Comment #14
joelpittetOne of the problems is I need to get out a version of ctools with #3464574: Missing config schema for entity_view block (D11+) so I will pivot there (before or after this release if I can get the ipe issues down, I know there are other ipe issues in the queue, might dig in on those)
Comment #15
joelpittetIPE is pointing to #3456918: IPE is entirely broken and there are a couple people there who want IPE to work.
Comment #16
japerryI agree with Joel, these tests need to be working before we make a release. I'll also take a look at ctools and see if that can be working, and have a release before we get panels out. @joelpittet, I'll be in slack tomorrow if you wanna coordinate on these!
Comment #17
joelpittetWill do @japerry, considering I think the ctools schema issue will be fixed in ctools (is that like a JS promise? 🤷♂️). If I get the IPE stuff sorted and that is all that is left I will make a release (regardless of the ctools schema issue, mid ground...)
Comment #18
liam morlandI agree that normally tests should be passing before making a release. The reason for this is to ensure there are no regressions. That reason doesn't apply for a PHP 8.4 compatibility release. We know for sure that fixing the type declarations does not break anything and does fix PHP 8.4 compatibility.
Comment #19
joelpittet@liam morland you might be technically right (the best kind of right?) but arguing over semantics (though a fun pass time) is just taking my attention away from fixing things and getting a release out... so I won't continue to address the argument in #18
Comment #21
joelpittetThe only remaining failure is
Drupal\Tests\panels\Functional\PanelsConfigSchemaTest::testPanelsConfigSchemawhich was fixed but unreleased in ctools #3464574: Missing config schema for entity_view block (D11+)I feel comfortable making a release knowing the rest of the CI errors are dealt with and IPE is in a better state.
Thank you all for bringing attention to this!
Comment #23
liam morlandThanks very much!