Closed (fixed)
Project:
Forward
Version:
8.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
24 Feb 2017 at 10:28 UTC
Updated:
20 Feb 2019 at 23:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Jasperh commentedThis patch adds the possibility to send a mail to multiple recipients.
The site builder can change the maximum allowed recipients in the settings, which defaults to one. When multiple recipients are allowed the input field for the recipients changes from a email field to a textarea. Where the user can enter one or more recipients separated by: space, komma, semicolon or enter. The input is checked for incorrect or duplicate email addresses and wether the number of recipients is higher than the maximum allowed number.
To preserve backwards compatibly the default value only allows one recipient and everything will look and work the same.
The patch also contains a update hook which adds the default value for the new variables.
Comment #3
john.oltman commentedThat's great @jasperh I'll take a look within the next few days. I have some other issues to address as well. It is probably time for a new release before the end of the year.
Comment #4
sutharsan commentedI mentored Jasperh when writing this code. The solution is solid and code looks good, except for the comments below.
I'm not particularly fond of the ForwardFormBuilder and all the services that are passed around to the form, but I did not really investigate that as it is existing code.
Please add an empty line at the end of this document.
Please add an empty line a the end of this document.
Will "empty" input of multiple spaces, or new lines get detected? (I did not test this) or is it detected by the default required field validation?
Comment #5
sutharsan commentedNeeds work...
Comment #6
john.oltman commentedI am wrapping up a different issue for Forward, once I get that issue committed I will try this out, sorry for the delay.
Comment #7
Jasperh commentedAdded empty lines and correct field validation for when the input only consists of whitespaces.
Comment #8
john.oltman commentedPatch needs to be re-rolled against latest Dev.
Comment #9
john.oltman commentedComment #10
Jasperh commentedPatch #7 re-rolled against latest dev.
Comment #12
john.oltman commentedAdded to rc2
Comment #13
john.oltman commentedComment #14
john.oltman commentedComment #15
john.oltman commented@Jasperh please install RC2 release and let me know if that works for you. If it does, I will do a general release of 8.x-2.2
Comment #16
Jasperh commented@john.oltman everything works fine for me
Comment #18
dwwAlas, this broke the submit handler for the forward form:
#3034561: Undefined variable: recipient in Drupal\forward\Form\ForwardForm->submitForm()
Anyone who worked on this issue is invited to help out over there.
Thanks!
-Derek
Comment #19
dwwAlso, RFC: #3034570: Limitations from having 'forward_max_recipients_error' as a config setting
Thanks,
-Derek