Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hi there, DrupalCI maintainer here.
We recently added javascript linting to the testrunners and it happens to be finding the ember app that you have embedded in your repository, which is huge, which is causing the testrunners to find several warnings in those files. And by several I mean 165,665 warnings - https://dispatcher.drupalci.org/job/drupal_contrib/11655/
Could you please add an .eslintignore file to your repo that excludes the ember/assets directory ? (see here for how: http://eslint.org/docs/user-guide/command-line-interface#ignoring-files-...)
Thank you.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | ignore_js_and_css-2855156-13.patch | 236 bytes | scor |
| #12 | ignore_js_and_css-2855156-12.patch | 234 bytes | scor |
| #11 | ignore_js_and_css-2855156-11.patch | 185 bytes | scor |
| #10 | ignore_js_and_css-2855156-10.patch | 184 bytes | scor |
| #2 | 2855156.eslintignore.2.patch | 236 bytes | eshta |
Comments
Comment #2
eshta commentedAttaching a patch for an .eslintignore file.
Comment #4
scor commentedThanks @eshta! It seems like Jenkins is a lot happier now at https://dispatcher.drupalci.org/job/drupal8_contrib_patches/426/: Checkstyle: 0 warnings. We'll include this in our next release. Thanks @Mixologic for noticing this and suggesting a fix.
Comment #6
scor commentedComment #7
scor commentedSadly I have to reopen this as it seems we still have a couple of warnings left according to the latest run at https://www.drupal.org/pift-ci-job/622505:
Comment #8
scor commentedAh, what's left are the CSS files. Sadly the csslint tool does not support .csslintignore(https://github.com/CSSLint/csslint/issues/330). @Mixologic any idea if there are any workarounds on d.o for this?
Comment #9
MixologicIt seems to be working for core: did you try a .csslintrc in your module's directory:
http://cgit.drupalcode.org/drupal/tree/.csslintrc#n39
Comment #10
scor commented@Mixologic I don't know why I didn't think to check core :(. Let's see what happens.
Comment #11
scor commentedprevious patch didn't work, trying again with different path.
Comment #12
scor commentedI don't know why it's not honoring the rule in the .csslintrc file. Trying with explicit filename to see if it makes any difference.
Comment #13
scor commentedeven a filename is not supported. trying relative path.
Comment #14
scor commentedCSS lint is still checking the file acquia_contenthub_subscriber/ember/assets/ch-ember-app-56e51d07e3a707e0d7ab170eb0cfcb77.css even though it's explicitely excluded in the .csslintrc file (https://www.drupal.org/pift-ci-job/630924). At this point I'm at a loss to understand what's going on. @Mixologic any idea?
Comment #15
scor commentedIt looks like the phpcs is no longer executed on patches? https://dispatcher.drupalci.org/job/drupal8_contrib_patches/5329/console shows "ERROR: the "Drupal" coding standard is not installed.". @Mixologic could you indicate what has changed on drupalCI?
Comment #16
MixologicA change to drupal core broke some assumptions that DrupalCI was making. This is fixed now.