\Drupal::database()-> must be used for building query.

Comments

chaitanya17 created an issue. See original summary.

chaitanya17’s picture

StatusFileSize
new2.96 KB

Please check attached working patch.

chaitanya17’s picture

Assigned: chaitanya17 » Unassigned
Status: Active » Needs review
papagrande’s picture

Status: Needs review » Needs work

@chaitanya17, thanks for the patch. Your changes make sense, but I wasn't able to apply your patch cleanly. Please reroll it based on https://www.drupal.org/node/707484 and name it based on https://www.drupal.org/patch/submit#patch_naming.

chaitanya17’s picture

Assigned: Unassigned » chaitanya17

Thanks @PapaGrande I will Correct the patch.

chaitanya17’s picture

StatusFileSize
new2.77 KB

Please check attached working patch.

chaitanya17’s picture

Assigned: chaitanya17 » Unassigned
Status: Needs work » Needs review

papagrande’s picture

Status: Needs review » Fixed
StatusFileSize
new2.86 KB

@chaitanya17, I still couldn't apply your patch cleanly so I fixed it and created a new one.

Also, note how I named the patch file per the guidelines at https://www.drupal.org/patch/submit#patch_naming. It makes it much easier to keep track of multiple patches.

Thanks for the help.

papagrande’s picture

Status: Fixed » Closed (fixed)
papagrande’s picture

Technically, my patch should have been named socrata-deprecated-db_select-2852862-9.patch since I pushed the commit before I uploaded my patch and the system created a new comment. Oh well.