Need to support language defaults.

CommentFileSizeAuthor
#7 interdiff.txt3.96 KBb_sharpe
#7 field_defaults-multilanguage-support-2848235-7.patch3.69 KBb_sharpe
#6 field_defaults-multilanguage-support-2848235-6.patch2.95 KBmylies
#4 field_defaults-multilanguage-support-2848235--4.patch1.96 KBb_sharpe
#4 interdiff.txt1.48 KBb_sharpe
#3 field_defaults-multilanguage-support-2848235-3.patch1.72 KBmylies

Comments

b_sharpe created an issue. See original summary.

mylies’s picture

mylies commented
Assigned: Unassigned » mylies
mylies’s picture

mylies commented
Assigned: mylies » Unassigned
Status: Active » Needs review
StatusFileSize
new field_defaults-multilanguage-support-2848235-3.patch1.72 KB

Added multilang support
Have a look)

b_sharpe’s picture

b_sharpe commented
Status: Needs review » Needs work
StatusFileSize
new interdiff.txt1.48 KB
new field_defaults-multilanguage-support-2848235--4.patch1.96 KB

Thanks. You're missing support for 'LANGCODE_NOT_SPECIFIED' and 'LANGCODE_NOT_APPLICABLE'. I've attached patch + interdiff for that; however, I think we need to account for each language separately rather than blindly overwrite translations with the default entity language.

Either as an option as the D7 version does (see screenshot on project page), or applied directly to the field translation form (which I'm currently thinking is blocked by some other issues as you can't set default value as far as I can see)

mylies’s picture

mylies commented
Assigned: Unassigned » mylies
mylies’s picture

mylies commented
Assigned: mylies » Unassigned
Status: Needs work » Needs review
StatusFileSize
new field_defaults-multilanguage-support-2848235-6.patch2.95 KB

I added checking languages like in D7 version
but, I don't have idea what do with 'Not specified' and 'Not applicable' langs - so it could be set to

b_sharpe’s picture

b_sharpe commented
StatusFileSize
new field_defaults-multilanguage-support-2848235-7.patch3.69 KB
new interdiff.txt3.96 KB

Needed to check if both bundle and field are translatable, as well as act upon non-translatable content. Also updated a few inline phpdoc entries. I've run this through with several scenarios without error. Would love a second set of eyes on this to RTBC as this should allow a good alpha release

  • 35ccea2 committed on 8.x-1.x 
    Issue #2848235 by b_sharpe, myLies: Defaults always in entity's default...
b_sharpe’s picture

b_sharpe commented
Status: Needs review » Fixed

Putting this in to push out a release for more testing, thanks myLies!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.