As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#13 interdiff-10-13.txt422 bytesnitin_lama
#13 2847943-updating-cs-13.patch2.15 KBnitin_lama
#10 removed-file-docblock-2847943-10.patch1.74 KBpatelmayank7552
#5 removed-file-docblock-2847943-5.patch908 bytesDeepthi kumari
#2 removed-file-docblock-2847943-2.patch690 bytesaks22

Issue fork video_embed_rutube-2847943

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aks22 created an issue. See original summary.

aks22’s picture

aks22 commented
Assigned: aks22 » Unassigned
Status: Active » Needs review
StatusFileSize
new removed-file-docblock-2847943-2.patch690 bytes
sam152’s picture

sam152 commented
Status: Needs review » Needs work 
FILE: ...eo_embed_rutube/src/Plugin/video_embed_field/Provider/Rutube.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
  7 | ERROR   | [ ] Missing short description in doc comment
 21 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 67ms; Memory: 6Mb

I prefer not to do these one at a time.

sam152’s picture

sam152 commented
Title: Remove @file tag docblock from all the .php files. » Fix all coding standards issues in module
Deepthi kumari’s picture

Deepthi kumari commented
Status: Needs work » Needs review
StatusFileSize
new removed-file-docblock-2847943-5.patch908 bytes

Updated Patch. Please review.

dipesh_goswami made their first commit to this issue’s fork.

dipesh_goswami’s picture

dipesh_goswami
Primary language English
commented
Assigned: Unassigned » dipesh_goswami

Hi @Deepthi kumari,
I am reviewing your patch.
Thanks.

dipesh_goswami’s picture

dipesh_goswami
Primary language English
commented
Assigned: dipesh_goswami » Unassigned
Status: Needs review » Needs work

Hi @Deepthi kumari,
Your patch applied cleanly.
Only this one issue left:

FILE: ...ideo_embed_rutube-2847943\src\Plugin\video_embed_field\Provider\Rutube.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 14 | WARNING | The class short comment should describe what the class does and
    |         | not simply repeat the class name
---------------------------------------------------

So, moving it to NW.
Thanks for your patch.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
patelmayank7552’s picture

patelmayank7552 commented
Assigned: nitin_lama » patelmayank7552
StatusFileSize
new removed-file-docblock-2847943-10.patch1.74 KB

@nitin_lama

I have fixed the coding standards.

Please review it.

patelmayank7552’s picture

patelmayank7552 commented
Status: Needs work » Needs review
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: patelmayank7552 » nitin_lama
Status: Needs review » Needs work

I was already working on it @patelmayank7552.
Please follow the contribution standards before working on an issue, as this doesn't leave a good impression on other contributors who are already working on it. Atleast wait for a day or two before assigning it to yourself. Also there are still some coding standard fixes left in your patch. Incoming patch !!
Thanks.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2847943-updating-cs-13.patch2.15 KB
new interdiff-10-13.txt422 bytes

Updated patch.

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

Hi nitin_lama,
i will review this patch.

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned

I reviewed and applied this patch cleanly, the patch fixed all phpcs issues, so I am transferring to RTBC.

/var/www/html/oslando/web/modules/contrib/video_embed_rutube (8.x-1.x) $ git apply -v /var/www/html/oslando/web/modules/contrib/video_embed_rutube/2847943-updating-cs-13.patch
Checking patch src/Plugin/video_embed_field/Provider/Rutube.php...
Checking patch video_embed_rutube.info.yml...
Applied patch src/Plugin/video_embed_field/Provider/Rutube.php cleanly.
Applied patch video_embed_rutube.info.yml cleanly.
atul@atul-Latitude-3420 /var/www/html/oslando/web/modules/contrib/video_embed_rutube (8.x-1.x) $ cd ../
atul@atul-Latitude-3420 /var/www/html/oslando/web/modules/contrib $ cd ../../
atul@atul-Latitude-3420 /var/www/html/oslando/web $ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml --encoding=utf-8 -p modules/contrib/video_embed_rutube/ --ignore=node_modules
.. 2 / 2 (100%)

Time: 71ms; Memory: 10MB

atul_ghate’s picture

atul_ghate commented
Status: Needs review » Reviewed & tested by the community

  • davps committed 156916e8 on 8.x-1.x authored by nitin_lama 
    Issue #2847943 by nitin_lama, aks22, dipesh_goswami, patelmayank7552,...
davps’s picture

davps commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.