I am receiving the error "TypeError: Argument 1 passed to Drupal\geocoder\Geocoder::reverse() must be an instance of double, float given, called in " and believe it has something to do with #2831732: Code Standards. Just wondering why double was chosen and not float?

CommentFileSizeAuthor
#6 2847892-geocoder-remove-reverse-hints.patch1.41 KBahebrank
#2 TypeError_must_be_an_instance_of_double_float_given-2847892.patch1.45 KBGravypower

Comments

Gravypower created an issue. See original summary.

Gravypower’s picture

Gravypower commented
StatusFileSize
new TypeError_must_be_an_instance_of_double_float_given-2847892.patch1.45 KB

Added in patch that changes the type to float so I can patch this module in my build.

Gravypower’s picture

Gravypower commented

So this may only be an issue with PHP 7, looking into this more now.

Gravypower’s picture

Gravypower commented

So this was an issue when using PHP 7

yoran scholiers’s picture

yoran scholiers commented

Had the same issue when trying to implement the Reverse method.
Also using PHP7. The patch above allows me to continue.

ahebrank’s picture

ahebrank commented
StatusFileSize
new 2847892-geocoder-remove-reverse-hints.patch1.41 KB

It may be better to remove the type hints entirely since the underlying dependency doesn't have them: https://github.com/geocoder-php/Geocoder/blob/master/src/Geocoder.php#L42

itamair’s picture

itamair commented
Priority: Normal » Critical

This patch seems to be essential to implement reverse geocoding in PHP 7,
thus (IMHO) should be committed ASAP and a new version of Geocoder released with it

  • Pol committed 138c550 on 8.x-2.x authored by ahebrank 
    Issue #2847892 by Gravypower, ahebrank: TypeError: Argument 1 passed to...
pol’s picture

pol
Location Brussels
commented
Status: Active » Fixed

Thanks, it's fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.