Currently the URL queuer is queueing everything dumbly including admin paths. In general paths accessed by authenticated users bypass external cache so do not need to be queued by url queuer. The decision method in the module should check for maxage < 0 and prevent them from being added to the url registry.

This change should dramatically reduce the number of records that in the purge_queuer_url table, and therefore reduce the number of external purges!

Comments

adam.weingarten created an issue. See original summary.

adam.weingarten’s picture

adam.weingarten’s picture

Issue summary: View changes
pedrop’s picture

Works for me, thanks!

vaibhavjain’s picture

Status: Active » Reviewed & tested by the community

This looks to be working good.

Steps to test:
# Login as a user, and visit a URL, say node/1.
# There is no entry to purge_queuer_url table.
# Visit the same page as Anonymous user, node/1
# There is an entry to purge_queuer_url table.

nielsvm’s picture

Status: Reviewed & tested by the community » Fixed

Also did some serious testing on this one, especially in combination with the other patches that just went in (e.g. auto-cleaning of deleted URLs)... Works really well, nice!

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

les lim’s picture

This caused a major regression, in which it's trivially easy to cause a URL to be removed from the purge_queuer_url traffic registry and prevent Drupal from ever invalidating the URL. See #2912139: Logged-in requests remove items from traffic registry #13 for an explanation and patch.