Problem/Motivation

Sips enables different kinds of payment methods (VISA/MASTERCARD/...)

Proposed resolution

Enable selection of those methods from the payment configuration.

Remaining tasks

-

User interface changes

Admin form only.

API changes

Config schema update.

Data model changes

Plugin config schema changes.

CommentFileSizeAuthor
#7 enable_different-2842445-7.patch7.02 KBborisson_
#7 interdiff.txt3.48 KBborisson_
#5 enable_different-2842445-5.patch3.54 KBborisson_

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Version: » 8.x-1.x-dev

Setting correct version.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Title: Enable different payment methods » Enable different payment methods selection
Issue summary: View changes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Related issues: +#2827144: Support multiple payment gateways on Checkout Payment information pane, +#2845072: Allow selection of payment method type for offsite payment gateways

Depending on the solution in #2845072: Allow selection of payment method type for offsite payment gateways, the implementation here could change.

The easy solution (from commerce's side) is that we provide a way to configure multiple gateways - each with their own brand.
This selection of brand would make it so that we create multiple gateways on the site (one per pre-selected brand), that's blocked on #2827144: Support multiple payment gateways on Checkout Payment information pane.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new enable_different-2842445-5.patch3.54 KB

Status: Needs review » Needs work

The last submitted patch, 5: enable_different-2842445-5.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.48 KB
new enable_different-2842445-7.patch7.02 KB

Add a little bit of extra testcoverage here.

No idea why that composer error is showing up.

Status: Needs review » Needs work

The last submitted patch, 7: enable_different-2842445-7.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review

Fixed the composer error in #2875750: Remove version from composer.json

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue summary: View changes

The patch in #7 adds a config schema change to add a sips_payment_method. This is used in the checkout to pass the brand param along to the remote api in \Drupal\commerce_worldline\TransformOrder::toPaymentRequest.

Solving the original problem by allowing for creation of multiple payment methods.

novitsh’s picture

novitsh commented
Status: Needs review » Reviewed & tested by the community

Looks good, setting to RTBC.

  • borisson_ committed 70063ed on 8.x-1.x 
    Issue #2842445 by borisson_, Novitsh: Enable different payment methods...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Committed, credited @Novitsh for the review (that was more extensive in slack)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.