Problem/Motivation
Sips enables different kinds of payment methods (VISA/MASTERCARD/...)
Proposed resolution
Enable selection of those methods from the payment configuration.
Remaining tasks
-
User interface changes
Admin form only.
API changes
Config schema update.
Data model changes
Plugin config schema changes.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | enable_different-2842445-7.patch | 7.02 KB | borisson_ |
Comments
Comment #2
borisson_Setting correct version.
Comment #3
borisson_Comment #4
borisson_Depending on the solution in #2845072: Allow selection of payment method type for offsite payment gateways, the implementation here could change.
The easy solution (from commerce's side) is that we provide a way to configure multiple gateways - each with their own brand.
This selection of brand would make it so that we create multiple gateways on the site (one per pre-selected brand), that's blocked on #2827144: Support multiple payment gateways on Checkout Payment information pane.
Comment #5
borisson_Comment #7
borisson_Add a little bit of extra testcoverage here.
No idea why that composer error is showing up.
Comment #9
borisson_Fixed the composer error in #2875750: Remove version from composer.json
Comment #10
borisson_The patch in #7 adds a config schema change to add a
sips_payment_method. This is used in the checkout to pass the brand param along to the remote api in \Drupal\commerce_worldline\TransformOrder::toPaymentRequest.Solving the original problem by allowing for creation of multiple payment methods.
Comment #11
novitsh commentedLooks good, setting to RTBC.
Comment #13
borisson_Committed, credited @Novitsh for the review (that was more extensive in slack)