Correct me if I'm wrong but this module doesn't currently allow a module to define component libraries. Is there a technical limitation to why this is? If not, can you give me some pointers on where to start so I can start working on a patch?

Further, everything I've seen so far seems to assume that components are a descendant of a theme folder. Is there a reason that this couldn't be changed to allow for more arbitrary location of components?

CommentFileSizeAuthor
#2 2837836-fix-module-info.patch1.21 KBaleksip

Comments

sonictruth created an issue. See original summary.

aleksip’s picture

aleksip
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 2837836-fix-module-info.patch1.21 KB

The current code expects module .info.yml file data to be in the Extension object, but that is not the case. Here is a patch that adds the info and makes it possible to define component libraries in modules as well.

robloach’s picture

robloach
he/him
commented

Nice work, @aleksip. Looks good... Should the system_get_info() call also apply to $type 'theme' too?

aleksip’s picture

aleksip
Primary language Finnish
Location Finland
commented

Thanks! Theme Extension objects already have the required info, so system_get_info() is needed for modules only.

robloach’s picture

robloach
he/him
commented
Status: Needs review » Reviewed & tested by the community

Sounds good!

robloach’s picture

robloach
he/him
commented

@aleksip Would you mind reviewing #2852837: Have Twig handle path errors ?

  • RobLoach committed 57259ca on 8.x-1.x authored by aleksip 
    Issue #2837836 by aleksip: Allow modules to define component libraries
robloach’s picture

robloach
he/him
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.