Hello,

When the webprofiler module is enabled there is a fatal error in /src/MenuBasedBreadcrumbBuilder.php because it uses EntityTypeManager instead of EntityTypeManagerInterface.

I will provide a patch for that.

CommentFileSizeAuthor
#2 menu_breadcrumb-using_entitytypemanager_instead_of_entitytypemanagerinterface-2830270-2.patch1.69 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs review
StatusFileSize
new menu_breadcrumb-using_entitytypemanager_instead_of_entitytypemanagerinterface-2830270-2.patch1.69 KB

Here is the patch.

Thanks for the review.

rphair’s picture

rphair commented

apologies for delay for such a simple fix, just back now from DrupalCamp on other side of country. Wondering now why EntityTypeManagerInterface wasn't in my Drupal 8 tags file!

  • rphair committed 2a6d7a8 on 8.x-1.x authored by Grimreaper 
    Issue #2830270 by Grimreaper, rphair: Using EntityTypeManager instead of...
rphair’s picture

rphair commented

have included this commit in 8.x-1.0-beta5 & please continue testing with webprofiler...

rphair’s picture

rphair commented
Status: Needs review » Fixed
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

No problem. Thanks for the commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned