Fix LingotekApiUnitTest failures.

See https://www.drupal.org/pift-ci-job/517172:

1) Drupal\Tests\lingotek\Unit\Remote\LingotekApiUnitTest::testGetProjects
Drupal\lingotek\Exception\LingotekApiException: Failed to get projects: Expectation failed for method name is equal to when invoked 1 time(s)
Parameter 1 for invocation Drupal\lingotek\Remote\LingotekHttpInterface::get('/api/project', Array (...)) does not match expected value.
Failed asserting that two arrays are equal.

/var/www/html/modules/lingotek/src/Remote/LingotekApi.php:218
/var/www/html/modules/lingotek/tests/src/Unit/Remote/LingotekApiUnitTest.php:145

2) Drupal\Tests\lingotek\Unit\Remote\LingotekApiUnitTest::testGetWorkflows
Drupal\lingotek\Exception\LingotekApiException: Failed to get workflows: Expectation failed for method name is equal to when invoked 1 time(s)
Parameter 1 for invocation Drupal\lingotek\Remote\LingotekHttpInterface::get('/api/workflow', Array (...)) does not match expected value.
Failed asserting that two arrays are equal.

/var/www/html/modules/lingotek/src/Remote/LingotekApi.php:253
/var/www/html/modules/lingotek/tests/src/Unit/Remote/LingotekApiUnitTest.php:178

FAILURES!
Tests: 8, Assertions: 9, Errors: 2.

CommentFileSizeAuthor
#14 fix_lingotekapiunittest-2822953-14.patch1.07 KBpenyaskito
#12 fix_lingotekapiunittest-2822953-12.patch1.2 KBpenyaskito
#10 fix_lingotekapiunittest-2822953-10.patch2.35 KBpenyaskito
#8 fix_lingotekapiunittest-2822953-8.patch1.07 KBpenyaskito
#5 2822953-2.empty_.patch0 bytespenyaskito
#5 2822953-2.append-root.patch3.87 KBpenyaskito
#4 2822953-2.empty_.patch0 bytespenyaskito
#4 2822953-2.append-root.patch3.87 KBpenyaskito
#2 2822953-2.append-root.patch3.87 KBpenyaskito
#2 2822953-2.empty_.patch0 bytespenyaskito

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2822953-2.empty_.patch0 bytes
new 2822953-2.append-root.patch3.87 KB

Testing appending $this->root as suggested by @tim.plunkett on IRC. Thanks also to @neclimdul and @mixologic for helping debugging those failures.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 2822953-2.append-root.patch3.87 KB
new 2822953-2.empty_.patch0 bytes

Reuploading, accidentally disabled patch testing settings in the project.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 2822953-2.append-root.patch3.87 KB
new 2822953-2.empty_.patch0 bytes

Status: Needs review » Needs work

The last submitted patch, 5: 2822953-2.empty_.patch, failed testing.

The last submitted patch, 5: 2822953-2.append-root.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new fix_lingotekapiunittest-2822953-8.patch1.07 KB

Status: Needs review » Needs work

The last submitted patch, 8: fix_lingotekapiunittest-2822953-8.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new fix_lingotekapiunittest-2822953-10.patch2.35 KB

New try?

Status: Needs review » Needs work

The last submitted patch, 10: fix_lingotekapiunittest-2822953-10.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new fix_lingotekapiunittest-2822953-12.patch1.2 KB

Oh, actually I missed a commit in HEAD.

Status: Needs review » Needs work

The last submitted patch, 12: fix_lingotekapiunittest-2822953-12.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new fix_lingotekapiunittest-2822953-14.patch1.07 KB

Proper patch.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Finally discovered that was a commit in HEAD increasing the limits on the API calls.

  • penyaskito committed 2756a46 on 8.x-1.x 
    Issue #2822953 by penyaskito: Fix LingotekApiUnitTest failures
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Committed 2756a46 and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.