Problem/Motivation

TwitterPostTokenManager was added when Rules did not allow to use Twig-style tokens. Now that Rules has allowed this functionality, it's time to update Social Post Twitter

Proposed resolution

Remove TwitterPostTokenManager and any reference to it from the module.

CommentFileSizeAuthor
#6 2821856-6.patch6.01 KBhardikpandya
#6 interdiff-2821856-3-6.txt4.52 KBhardikpandya
#3 2821856-3.patch3.06 KBfelribeiro

Comments

gvso created an issue. See original summary.

gvso’s picture

gvso
Primary language Spanish
commented
Issue summary: View changes
felribeiro’s picture

felribeiro commented
Status: Active » Needs review
StatusFileSize
new 2821856-3.patch3.06 KB
gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs review » Needs work

Thanks for your patch. However, there are many things that should also be removed/changed; for instance, the file TwitterPostTokenManager.php is not deleted. Plus, the description for the Tweet Rule action should be modified.

Those are the main things I have found, but there may be other changes that should be applied.

hardikpandya’s picture

hardikpandya commented
Assigned: Unassigned » hardikpandya
hardikpandya’s picture

hardikpandya commented
Assigned: hardikpandya » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff-2821856-3-6.txt4.52 KB
new 2821856-6.patch6.01 KB
gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs review » Needs work
Issue tags: +GCI16 
+++ b/src/Plugin/RulesAction/Tweet.php
@@ -94,6 +94,7 @@ class Tweet extends RulesActionBase implements ContainerFactoryPluginInterface {
+    $this->tokenManager = $token_manager;

Because the service was removed, this variable will cause an error

Additionally, we need to change the description in the @RulesAction annotation.

  • gvso committed be4c207 on 8.x-1.x 
    Issue #2821856 by hardik.p, felribeiro, gvso: Remove...
gvso’s picture

gvso
Primary language Spanish
commented

Issue fixed to realease alpha 1

gvso’s picture

gvso
Primary language Spanish
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.