Problem/Motivation

There is an edge case when we upload a document that has manual upload. After editing, if we have requested a translation, and then update it, we are marking the target statuses that were not downloaded as available for request. But if it was already requested, we cannot move forward with the links themselves.

Proposed resolution

When a target status is PENDING, we should never update it to REQUEST.

Remaining tasks

Create a patch with a failing test + fix

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

Status: Active » Needs review
StatusFileSize
new2.78 KB

A failing test.

penyaskito’s picture

StatusFileSize
new8.6 KB

Failing tests for content, config, fields and config entities.

penyaskito’s picture

StatusFileSize
new12.65 KB
new8.6 KB

Added fix + tests.

Status: Needs review » Needs work

The last submitted patch, 2: 2820142-2.should-fail.patch, failed testing.

The last submitted patch, 2: 2820142-2.should-fail.patch, failed testing.

The last submitted patch, 2: 2820142-2.should-fail.patch, failed testing.

The last submitted patch, 3: 2820142-3.should-fail.patch, failed testing.

The last submitted patch, 3: 2820142-3.should-fail.patch, failed testing.

The last submitted patch, 3: 2820142-3.should-fail.patch, failed testing.

The last submitted patch, 4: 2820142-4.only-tests.patch, failed testing.

The last submitted patch, 4: 2820142-4.only-tests.patch, failed testing.

The last submitted patch, 4: 2820142-4.only-tests.patch, failed testing.

penyaskito’s picture

Status: Needs work » Reviewed & tested by the community

Tests passed and failed as expected.

  • penyaskito committed cfc6b17 on 8.x-1.x
    Issue #2820142 by penyaskito: When a target status is PENDING, we should...
penyaskito’s picture

Status: Reviewed & tested by the community » Fixed

Committed cfc6b17 and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.