Coding standard issues fixing.

CommentFileSizeAuthor
#5 interdiff-2819545-2-5.txt18.04 KBbrolad
#5 interdiff-2819545-2-5.patch18.04 KBbrolad
#5 address-fix_coding_standard-2819545-5.patch31.14 KBbrolad
#2 fix_coding_standard-2819545-2.patch43.15 KBdeepa_lissa

Comments

deepal_zyxware created an issue. See original summary.

deepa_lissa’s picture

deepa_lissa commented
StatusFileSize
new fix_coding_standard-2819545-2.patch43.15 KB

I have created a patch for the issue "Fix Coding Standard Issues". Please review.

deepa_lissa’s picture

deepa_lissa commented
Status: Active » Needs review
bojanz’s picture

bojanz commented
Status: Needs review » Needs work

You should not be changing the README, it is not a subject to coding standards, since it's not code.
You should not be adding @file docblocks to classes, the coding standard omits them.

brolad’s picture

brolad commented
StatusFileSize
new address-fix_coding_standard-2819545-5.patch31.14 KB
new interdiff-2819545-2-5.patch18.04 KB
new interdiff-2819545-2-5.txt18.04 KB
brolad’s picture

brolad commented
Status: Needs work » Needs review

  • bojanz committed aa0456a on 8.x-1.x authored by Arez 
    Issue #2819545 by Arez, deepal_zyxware, bojanz: Fix Coding Standard...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Added a phpcs.xml for future testing, and merged the provided patches with my own fixes.
Thanks, everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.