CommentFileSizeAuthor
#7 issue-2812849-verify_email-7.patch1.24 KBnerdstein
#6 issue-2812849-verify_email-6.patch0 bytesnerdstein
#4 issue-2812849-verify_email-4.patch1.24 KBnerdstein
#2 2812849-verify-email-fix.patch953 bytesbobooon

Comments

robphillips created an issue. See original summary.

bobooon’s picture

bobooon commented
Status: Active » Needs review
StatusFileSize
new 2812849-verify-email-fix.patch953 bytes

Patch attached.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

Thank you for working on this. I've done a code review and this makes sense. I want to test this manually and will try to do so tomorrow.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
StatusFileSize
new issue-2812849-verify_email-4.patch1.24 KB

Manual code review looks good.

The patch did not apply cleanly from recent commits. I created a new patch.

I added some additional logic for the proper return types.

Setting to "needs review"

mroycroft’s picture

mroycroft commented

Code looks good, but haven't done any manual testing.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
StatusFileSize
new issue-2812849-verify_email-6.patch0 bytes

New rebased patch attached

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
StatusFileSize
new issue-2812849-verify_email-7.patch1.24 KB

Apologies on the last patch...

This one works and I have performed smoke testing.

Merging.

The last submitted patch, 2: 2812849-verify-email-fix.patch, failed testing.

  • nerdstein committed bba8e0b on 8.x-3.x 
    Issue #2812849 by nerdstein, robphillips: Unable to register account...
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Needs review » Fixed

Pushed up to 8.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.