new pattern types don't show after saving settings form

Can't reproduce this. Went to the add form first, then visited the settings page enabled one (Poll in my case), went back to add and it was shown by default.

We also have \Drupal\pathauto\Tests\PathautoEnablingEntityTypesTest::testEnablingEntityTypes that works without a cache clear. It doesn't use the UI to create the type, feel free to change that if you think that might make a difference.

Ok, was able to reproduce this kind of after a new install but actually not exactly like you said.

After a clean install, user is already enabled in the settings. But it doesn't show yet. Saving after checking another then works.

The reason is then that we only clear the cache in the UI when the types actually change. I think user was already enabled in your case.

The logic in \Drupal\pathauto\Form\PathautoSettingsForm::submitForm() needs to move to a config save event subscriber, similar to \Drupal\redirect\EventSubscriber\RedirectSettingsCacheTag.

I can replicate this too, starting investigation

Freeing up ticket

Updating description

Created an event subscriber which clears fielddefinition.
Removed cache clearing logic from submitForm() as given in issue description.

Kindly Review! Thanks !!

That works,
Enabling module, user shows up without adjusting settings page on Add pathauto pattern page.

+++ b/src/Form/PathautoSettingsForm.php
@@ -260,12 +260,6 @@ class PathautoSettingsForm extends ConfigFormBase {
 
-    // Clear cached field definitions if the values are changed.
-    if ($original_entity_types != $config->get('enabled_entity_types')) {
-      $this->entityFieldManager->clearCachedFieldDefinitions();
-      $this->aliasTypeManager->clearCachedDefinitions();
-    }
-

Here we had logic that the settings actually changed, that means we're now doing more cache clears than we need to.

We should be able to use https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Config%21... for that.

Also, a test would be great

Hi @Berdir,

I have updated the patch which checks for getOriginal() values of config.

Kindly help me here!
As far as writing test is concerned, I'm writing drupal test for first time. I have managed to write a test case, but problem I'm having here is to which values to assert as described below:

- When I try to check default values of $this->config('pathauto.settings') it shows an array with single value "node" in it.
- There are two default values(Content & Taxonomy) are already checked in settings page.
- And, when we navigate to /admin/config/search/path/patterns/add it has 3 values initially.
- So, which two values to check to confirm our test case.

Thanks!

I need to have a look at this myself. Thanks for the patch, will try to test this next week.

Re ran the test, it passed.

Here's a test for this, by using the API to change the settings and verify that the things were updated that need to.

Reproducing in the UI is complicated I think.

Committed, thanks everyone.