Problem/Motivation

CDN list in the admin page is empty.

Proposed resolution

Fix the JSON syntax error in _bootstrap_library_data(), so that we get the list

Remaining tasks

Patch,
Test,
Review

User interface changes

Gets options in list.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#10 cdn-json-issue-2801993-10.patch729 bytesdanharper
#4 2801993-4.png335.79 KBvijaycs85
#3 2801993-3.patch1.98 KBvijaycs85
#3 2801993-3-test_only.patch1.42 KBvijaycs85
#2 2801993-2.patch581 bytesvijaycs85
#2 2801993-2-not-working.png27.65 KBvijaycs85
#2 2801993-2-working.png73.69 KBvijaycs85

Comments

vijaycs85 created an issue. See original summary.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2801993-2-working.png73.69 KB
new 2801993-2-not-working.png27.65 KB
new 2801993-2.patch581 bytes
vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 2801993-3-test_only.patch1.42 KB
new 2801993-3.patch1.98 KB

Adding some tests and we have to get #2802005: Enable automation testing for this project in to send to QA server. It's all green locally.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 2801993-4.png335.79 KB
hatuhay’s picture

hatuhay commented
Status: Needs review » Fixed

Fixed on 8.x-1.5 release that was not published...

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Fixed » Needs review

ok, But we could probably use the test added here?

hatuhay’s picture

hatuhay commented
Status: Needs review » Closed (outdated)
danharper’s picture

danharper commented
Version: 8.x-1.x-dev » 8.x-1.12

I'm have this issue, it looks like json_decode on line 53 is not decoding the returned output from _bootstrap_library_data 

    $data = _bootstrap_library_data();
    $cdn_options =  json_decode( $data );

Results in $cdn_options being null.

Error is malformed json on line 320 of BootstrapLibrarySettingsForm.php, there is 

    "5.13.0": "//cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/css/all.min.css"

Should be

    "5.13.0": "//cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/css/all.min.css",

Cheers Dan

pegasus360’s picture

pegasus360 commented

Thanks Dan Harper.
Had the same problem and your solution worked.

danharper’s picture

danharper commented
Status: Closed (outdated) » Needs review
StatusFileSize
new cdn-json-issue-2801993-10.patch729 bytes

Patch attached

  • hatuhay committed 1f00c93 on 8.x-1.x authored by danharper 
    Issue #2801993 by vijaycs85, danharper: CDN list is empty - Syntax error...
  • hatuhay committed d453345 on 8.x-1.x authored by danharper
    Issue #2801993 by vijaycs85, danharper: CDN list is empty - Syntax error...
hatuhay’s picture

hatuhay commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.