hook_requirements() should only be info if social share plugin is not used

Check if there are config entities that have it selected, should be easy with an entity query.

I think you can get the libraries definition yes and then if it is defined and has the library file then you can assume it is there. which won't be the case since demo doesn't depend on libraries I think?

also hardcoding that path is definitely wrong, that's what the libraries module is for, which should be used to find that path for us.

+++ b/sharemessage.install
@@ -52,20 +52,31 @@ function sharemessage_requirements($phase) {
+    if (\Drupal::moduleHandler()->moduleExists('libraries')) {
+      $directory = libraries_get_path('socialshareprivacy');
+    };
+    $has_social_share = is_file($directory . '/jquery.socialshareprivacy.min.js');

this makes no sense if $directory is an empty string, you'd look for this file in the top drupal folder.

The whole check can only be done if libraries.module is installed.

However, there clearly is more wrong here. We need to have something clean before we can continue here.

Have a look at the sharre integration, with hook_libraries_info() and hook_library_info_alter(). socialshareprivacy must work in the same way, so that you can for example move the files to sites/all/libraries and it will still work.

Once we have that, we can continue with the requirements hook, which we should do for sharre as well. I'm fine with cleaning up here, but we could also postpone on another issue first.

I'm more and more confused about how we integrate this.

The file structure we have seems pretty made up. the files exist, but you can't just download them like that from anywhere, but have to download the single files and put them together. And the library is pretty old and hasn't been updated in 2years.

There's another version here https://github.com/patrickheck/socialshareprivacy, fewer forks/likes, but is available as a bower library.

Here's a patch that works, but we need to discuss about what we want to do with this exactly. Was hoping to do release once this is fixed but not sure right now.

Committed, this is definitely an improvement already and doesn't make anything worse.