Any change to get integration to IMCE?

It would be great if ImageWidget crop widged had "Allow users to select files from Imce File Manager for this field." checkbox. See attached screenshot.

Comments

ladyofthelake created an issue. See original summary.

woprrr’s picture

Hii thank a lot for your feedback and idea !!!

Is true for me imce is not needded in my usecases i prefer entitybrowser approach. I can purpose that if IMCE is installed create an sumodule to Provide an widget compatible with IMCE checkbox (is just an widget to extend iwc class to add this feature).

I Check possibilities in my come back but really good idea :) if you need participate to this subproject you are free i love Work with iwc users to have best crop feature.

ladyofthelake’s picture

Hi, sorry for the late reply!

Thanks for looking on this. I would also prefer Entity Browser, but it doesn't work as it should be. So until they get it production ready it's IMCE - which is much easier to work with btw.

I'm not much of a coder myself, but I'd really like to have IMCE support to Image Widget Crop :-)

Lena

xem8vfdh’s picture

+1, this would be awesome!

woprrr’s picture

hi @all :) i think we can discuss about it more free in (imagewidgetcrop.slack.com) dedicated slack. I can purpose to see all possibilites & usecase about this feature request during DrupalCon dublin IWC sprint.

xem8vfdh’s picture

I'm not sure I will be able to make it to the slack chat room, but I'm envisioning a simple duplication of an IMCE configuration that gets injected into the Manage Form Display page for simple Image fields. Once you've installed IMCE on Drupal 8, you can create an image field on a content type (or simply look at one you've already created), then go into "Manage Form Display" for the content type, click the configuration/settings gear icon on the right side of the window for the field in question, and you will see an option to "Allow users to select files from Imce File Manager for this field." [see attached imce_manage_form_display_configuration.png file].

Once you've done this, if you create/edit a record for this content type, you will see a new option on the field in question to "Open File Browser" [see attached open_file_browser_option.png file]. You can click this option, instead of the standard "Choose Files" option to select files from the server instead of uploading a new file.

You can see how IMCE is building/handling this configuration option by doing the following in a ssh terminal session:

$ git clone git://git.drupal.org/project/imce.git
Cloning into 'imce'...
remote: Counting objects: 2592, done.
remote: Compressing objects: 100% (1487/1487), done.
remote: Total 2592 (delta 1720), reused 1610 (delta 1068)
Receiving objects: 100% (2592/2592), 751.85 KiB | 0 bytes/s, done.
Resolving deltas: 100% (1720/1720), done.
Checking connectivity... done.
$ cd imce
$ git checkout 8.x-1.x
$ grep -rF 'Allow users to select files' *

The configuration is set up in src/ImceFileField.php

tjerkr’s picture

Thanks to xeM8VfDh for pointing out the file location src/ImceFileField.php.
I was able to make a patch file for imce to add this option to the Image Widget Crop widget.
Referring to the patch in the attachment.

woprrr’s picture

I see that as soon as possible Thanks a lot guys !

xem8vfdh’s picture

Thank YOU @woprrr and @tjerkr

woprrr’s picture

Issue tags: -ImageWidgetCrop Dublin Sprint +D8Media, +DevDays Seville
woprrr’s picture

Status: Active » Needs review
StatusFileSize
new553 bytes

Hi guys,

This patch solve the problem and assume the support request. @tjerkr Sorry to change your patch totally but this isn't work for IMCE. He have create an hook to permit other module to integrate her widget to supported list.

Can you test it fast and tell me if all is okay, I need to integrate this on next release :).

duaelfr’s picture

Issue tags: -DevDays Seville +DevDaysSeville

Fixing event tag

xem8vfdh’s picture

Thanks @woprrr!

woprrr’s picture

Status: Needs review » Reviewed & tested by the community

Ready to integrate future release :). I merge it during my sprint night ;)

xem8vfdh’s picture

Great work @woprrr! You've got to be one of the most responsive devs on drupal.org. I for one really appreciate the hard work and rapid response rate!

  • woprrr committed 67589ca on 8.x-1.x
    Issue #2787953 by woprrr, tjerkr, xeM8VfDh, ladyofthelake: Integration...
woprrr’s picture

Status: Reviewed & tested by the community » Fixed

Merged Thanks guys.

Thank @xeM8VfDh it motivate me a lot to increase quality of this module !

  • woprrr committed 67589ca on 8.x-2.x
    Issue #2787953 by woprrr, tjerkr, xeM8VfDh, ladyofthelake: Integration...
woprrr’s picture

Status: Fixed » Closed (fixed)