First of all thanks for this great module
The 8.x branch is a little outdated and doesn't work with the latest version of the core. I would like to help you with this branch.
I wrote an updated version of the module based on the version attached in #1741498: Add a responsive preview bar to Drupal core (that seems to be more up to date than the code in the repository). You can check out the code here https://github.com/willzyx-dev/responsive_preview. The work is quite complete and the module seems to works well :)
Let me now if you are interested in merge the code.
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | make_8_x_branch_works-2786391-3.patch | 147.96 KB | chr.fritsch |
Comments
Comment #2
chr.fritschI've reviewed the github project and made a view changes. The complete work can be found at https://github.com/BurdaMagazinOrg/responsive_preview
So IMHO we are in a good state to push this as a 8.x-1.x branch
Comment #3
chr.fritschHere is also a patch which applies to the latest 8.x branch
Comment #4
phjouI've just tested the module from github and it works very well. Merge the patch is a really good idea. Well done.
However, I encountered one problem but it is another issue. The module always do http request and when you are on a https website, the preview is blocked by the browser. Should I create another issue in Drupal even the github branch is not merged yet.
Comment #6
chr.fritschPatch is applied now. Big thanks to willzyx