First of all thanks for this great module

The 8.x branch is a little outdated and doesn't work with the latest version of the core. I would like to help you with this branch.
I wrote an updated version of the module based on the version attached in #1741498: Add a responsive preview bar to Drupal core (that seems to be more up to date than the code in the repository). You can check out the code here https://github.com/willzyx-dev/responsive_preview. The work is quite complete and the module seems to works well :)

Let me now if you are interested in merge the code.

Thanks!

CommentFileSizeAuthor
#3 make_8_x_branch_works-2786391-3.patch147.96 KBchr.fritsch

Comments

willzyx created an issue. See original summary.

chr.fritsch’s picture

Status: Needs review » Reviewed & tested by the community

I've reviewed the github project and made a view changes. The complete work can be found at https://github.com/BurdaMagazinOrg/responsive_preview

So IMHO we are in a good state to push this as a 8.x-1.x branch

chr.fritsch’s picture

StatusFileSize
new147.96 KB

Here is also a patch which applies to the latest 8.x branch

phjou’s picture

I've just tested the module from github and it works very well. Merge the patch is a really good idea. Well done.

However, I encountered one problem but it is another issue. The module always do http request and when you are on a https website, the preview is blocked by the browser. Should I create another issue in Drupal even the github branch is not merged yet.

  • chr.fritsch committed 979a3ec on 8.x-1.x
    Issue #2786391 by chr.fritsch, willzyx: Make 8.x branch works with...
chr.fritsch’s picture

Status: Reviewed & tested by the community » Fixed

Patch is applied now. Big thanks to willzyx

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.